Incorrect message and delete your favorite folder (file) from the folder "On device"

[Valdnet]

1. For a folder - "On device".

Actual behaviour

• Erroneous question when deleting a folder.

Expected behaviour

• The correct question when removing the folder.

Steps to reproduce

1. Create a folder.
2. Mark the folder as a favorite.
3. Save to device.
4. Open from the menu "On device".
5. Delete your favorite folder.

2. For a file - "On device".

Actual behaviour

• Erroneous question when deleting a file.

Expected behaviour

• The correct question when removing the file.

Steps to reproduce

1. Create a file.
2. Mark the file as a favorite.
3. Save to device.
4. Open from the menu "On device".
5. Delete your favorite file.

Environment data

Android version: 6
Nextcloud app version: daily dev 20190306 commit: 7e1424a
Nextcloud server version: 15.0.4

[nextcloud-android-bot]

GitMate.io thinks possibly related issues are #2281 ([Deleted]), #687 (Favorites), #3534 (Watch folders for deleted files and delete from Nextcloud), #2382 (Delete multiple files), and #3212 (Crash when loading "Deleted files").

[tobiasKaminsky]

Can you translate the dialogs so that we can understand what the problem is?

[Valdnet]

@tobiasKaminsky i translated the dialogs.

[tobiasKaminsky]

This was done on purpose:

• if you are "on device" you only shall delete files/folders "on device"
• if you are on "all files" you can decide whether to delete files/folders only on device or both.

[Valdnet]

The error applies only to the favorite folder or file that is on "On device".

The following question arises:

When confirming the deletion, the file is removed from the device and from the main folder.

The question should be a choice from which location to delete.

Please, analyze again "Steps to reproduce" 😉

[Valdnet]

@tobiasKaminsky if you confirm the error, please re-open issues 😉

[tobiasKaminsky]

Now I understand.
Thank you for finding & reporting this bug!

[tobiasKaminsky]

Reference: #2718

@AndyScherzinger I am not quite sure about this long issue (#2718), but somwhere it is stated that remove should work the same on "on device" and "all files".

For some reason this was included:

android/src/main/java/com/owncloud/android/ui/dialog/RemoveFilesDialogFragment.java

Lines 100 to 102 in 8971dc1

	int localRemoveButton = (!containsFavorite && (containsFolder || containsDown)) ?
	R.string.confirmation_remove_local :
	-1;

--> I would simply kill this: so you can delete everything if you want and always get the choice "yes, no, only local".

[tobiasKaminsky]

To check:

• create a f1/f2/2.txt
• download this file
• go to on device
• delete f1
• should offer "only local", which then removes f1 locally recursive

[AndyScherzinger]

--> I would simply kill this: so you can delete everything if you want and always get the choice "yes, no, only local".

@tobiasKaminsky agreed, I'd also vote for always having all options when it comes to "delete"

[AndyScherzinger]

ships with v3.6.0 🎉