Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm() when deleting a calendar/event #341

Closed
georgehrke opened this issue Feb 13, 2017 · 8 comments · Fixed by #349
Closed

Add confirm() when deleting a calendar/event #341

georgehrke opened this issue Feb 13, 2017 · 8 comments · Fixed by #349
Assignees
Labels
3. to review Waiting for reviews enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@georgehrke
Copy link
Member

Yes, blocking modals suck, but right now there is no undo action. We are at a dead end with #148 and #149 and it will take at least another 2 or 3 months before nextcloud/server#1662 is implemented and released as stable.

A blocking modals still sucks less than accidentally loosing an entire calendar.

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Feb 13, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone Feb 13, 2017
@georgehrke georgehrke self-assigned this Feb 13, 2017
@raimund-schluessler
Copy link
Member

I know, @jancborchardt does not like modals, but maybe you want to have a look how the Tasks app does it: owncloud/tasks#354.

@georgehrke
Copy link
Member Author

Really like that idea :)

Will probably use it here too.

@jancborchardt
Copy link
Member

Ok … but I really hope we can gonforward with undo.

cc @nextcloud/javascript @ChristophWurst

@brantje
Copy link
Member

brantje commented Feb 16, 2017

It's possible to replace the default confirm function with a more styled one.
Example here: http://jsfiddle.net/k5uDw/16/

@skjnldsv
Copy link
Member

Careful, the undo on tasks doesn't fit the css guidelines!

@raimund-schluessler
Copy link
Member

Careful, the undo on tasks doesn't fit the css guidelines!

Yes, the implementation in the Tasks app is older than nextcloud/server#3024

@georgehrke
Copy link
Member Author

doesn't fit the css guidelines

Can I find these guidelines somewhere? ;)

@skjnldsv
Copy link
Member

@georgehrke nextcloud/server#2798
And https://docs.nextcloud.com/server/11/developer_manual/app/css.html

Not fully completed. Dev manual will be updated asap (need free time 😢 )

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants