-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirm() when deleting a calendar/event #341
Comments
I know, @jancborchardt does not like modals, but maybe you want to have a look how the Tasks app does it: owncloud/tasks#354. |
Really like that idea :) Will probably use it here too. |
Ok … but I really hope we can gonforward with undo. cc @nextcloud/javascript @ChristophWurst |
It's possible to replace the default confirm function with a more styled one. |
Careful, the undo on tasks doesn't fit the css guidelines! |
Yes, the implementation in the Tasks app is older than nextcloud/server#3024 |
Can I find these guidelines somewhere? ;) |
@georgehrke nextcloud/server#2798 Not fully completed. Dev manual will be updated asap (need free time 😢 ) |
Yes, blocking modals suck, but right now there is no undo action. We are at a dead end with #148 and #149 and it will take at least another 2 or 3 months before nextcloud/server#1662 is implemented and released as stable.
A blocking modals still sucks less than accidentally loosing an entire calendar.
The text was updated successfully, but these errors were encountered: