From d4284e1e9c84b4ed967eabb8b64a7fb23ae9e69b Mon Sep 17 00:00:00 2001
From: Maxence Lange <maxence@artificial-owl.com>
Date: Wed, 12 Jul 2023 11:34:02 -0100
Subject: [PATCH] group can contains '@'

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
---
 lib/Service/FederatedUserService.php | 32 +++++++++++++++++-----------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/lib/Service/FederatedUserService.php b/lib/Service/FederatedUserService.php
index e3fd406bd..7a30e81f7 100644
--- a/lib/Service/FederatedUserService.php
+++ b/lib/Service/FederatedUserService.php
@@ -721,14 +721,22 @@ public function getFederatedMember(string $userId, int $level = Member::LEVEL_ME
 	 * @throws RequestBuilderException
 	 */
 	public function getFederatedUser(string $federatedId, int $type = Member::TYPE_SINGLE): FederatedUser {
-		// if type=user, we check that handle@domain is not an actual local user
-		if ($type === Member::TYPE_USER) {
-			try {
-				return $this->getLocalFederatedUser($federatedId);
-			} catch (Exception $e) {
+		// first testing federatedId string as a whole;
+		try {
+			switch ($type) {
+				case Member::TYPE_USER:
+					return $this->getLocalFederatedUser($federatedId);
+				case Member::TYPE_GROUP:
+					return $this->getFederatedUser_Group($federatedId);
+				case Member::TYPE_MAIL:
+					return $this->getFederatedUser_Mail($federatedId);
+				case Member::TYPE_CONTACT:
+					return $this->getFederatedUser_Contact($federatedId);
 			}
+		} catch (Exception $e) {
 		}
 
+		// then if nothing found, extract remote instance from string
 		[$singleId, $instance] = $this->extractIdAndInstance($federatedId);
 
 		switch ($type) {
@@ -739,10 +747,6 @@ public function getFederatedUser(string $federatedId, int $type = Member::TYPE_S
 				return $this->getFederatedUser_User($singleId, $instance);
 			case Member::TYPE_GROUP:
 				return $this->getFederatedUser_Group($singleId, $instance);
-			case Member::TYPE_MAIL:
-				return $this->getFederatedUser_Mail($federatedId);
-			case Member::TYPE_CONTACT:
-				return $this->getFederatedUser_Contact($federatedId);
 		}
 
 		throw new UserTypeNotFoundException();
@@ -879,14 +883,14 @@ private function getFederatedUser_User(string $userId, string $instance): Federa
 	 * @throws UnknownRemoteException
 	 * @throws RequestBuilderException
 	 */
-	public function getFederatedUser_Group(string $groupName, string $instance): FederatedUser {
+	public function getFederatedUser_Group(string $groupName, string $instance = ''): FederatedUser {
 		if ($this->configService->isLocalInstance($instance)) {
 			$circle = $this->getGroupCircle($groupName);
 			$federatedGroup = new FederatedUser();
 
 			return $federatedGroup->importFromCircle($circle);
 		} else {
-			// TODO: implement remote groups
+			throw new FederatedUserNotFoundException('remote group not supported yet. Use singleId');
 		}
 	}
 
@@ -948,11 +952,13 @@ public function getFederatedUser_Contact(string $contactPath): FederatedUser {
 	 */
 	public function extractIdAndInstance(string $federatedId): array {
 		$federatedId = trim($federatedId, '@');
-		if (strrpos($federatedId, '@') === false) {
+		$pos = strrpos($federatedId, '@');
+		if ($pos === false) {
 			$userId = $federatedId;
 			$instance = $this->interfaceService->getLocalInstance();
 		} else {
-			[$userId, $instance] = explode('@', $federatedId);
+			$userId = substr($federatedId, 0, $pos);
+			$instance = substr($federatedId, $pos + 1);
 		}
 
 		return [$userId, $instance];