Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card title overflows/goes under the card-options button #131

Closed
pixelipo opened this issue May 10, 2017 · 6 comments
Closed

Card title overflows/goes under the card-options button #131

pixelipo opened this issue May 10, 2017 · 6 comments

Comments

@pixelipo
Copy link
Contributor

See screenshot for two (related) problems:

title-overflow

It's really simple to fix - I'll create a PR tomorrow

@x9t9
Copy link
Collaborator

x9t9 commented May 11, 2017

I would suggest moving it altogether somewhere else , instead of trying to fix it .
I believe that from UX point of view, and in consideration of future functions / icons / metadata , All of them should be concentrated in a footer / header part of card .
( Same problem exists BTW also in the stack title )
Another issue related to this icon ( which maybe should not be an icon but simply text based 3 points ) is that maybe another menu item , of display / edit / open details should be there , and not by clicking the card title ( which sometimes create problems when dragging )

@pixelipo
Copy link
Contributor Author

@x9t9 it would be awesome if you (or anyone) would come up with a comprehensive design strategy for this project. That would really simplify development.

However, until we have something like that, I would consider this a bug to be fixed.

Regarding this particular issue, title is header, right? So even if we set a static position for buttons, the issue persists. Looking at Trello, they keep a similar button in the top-right corner and it often goes over card title. However, their button has a gray background on hover, so it's not as bad (but I still don't this it's a great solution):
image

@pixelipo
Copy link
Contributor Author

By the way, thanks for noticing a similar issue with the stack title. The problem there is actually even worse - because <h2> element contains a block element <div class="stack-actions"> which is not a valid HTML code.

@juliushaertl juliushaertl added this to the 0.2.0 milestone May 18, 2017
@artemanufrij
Copy link
Member

@pixelipo are you working on this issue?

@pixelipo
Copy link
Contributor Author

@artemanufrij I totally forgot about this issue. I have the code ready, I jest need to rebase and push. PR will be ready for review today.

@artemanufrij
Copy link
Member

@pixelipo ok, it would be cool if you push it today. At the moment I make a small card redesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants