Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attaching a file to a card via ‘Share from files’ does not work #5935

Closed
PatrickJosh opened this issue May 25, 2024 · 9 comments · Fixed by #5964 or #6038
Closed

Attaching a file to a card via ‘Share from files’ does not work #5935

PatrickJosh opened this issue May 25, 2024 · 9 comments · Fixed by #5964 or #6038
Assignees
@elzody
Labels
bug

Comments

@PatrickJosh
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
Since the upgrade to Nextcloud 29.0.1 (from 28.0.6), attaching files to cards using the ‘Share from files’-button does not work any more. It still opens the file picker, but the directory tree looks like it is fetching, indefinitely. I attached a screenshot to the screenshot section.

Moreover, the browser's console shows this error in the console when opening the file picker:

22:10:47.630 TypeError: t is undefined
    H request.js:71
    de index.mjs:405
    get index.js:2
    execute index.js:2
    patchInline index.js:2
    X index.js:2
    Q index.js:2
    W index.js:2
    Ft index.js:2
    Ft index.js:2
    getDirectoryContents index.js:2
    d FilePicker-oSc3I_BN.mjs:876
    loadFiles FilePicker-oSc3I_BN.mjs:887
    setup FilePicker-oSc3I_BN.mjs:966
    VueJS 25
    render legacy.mjs:36
    VueJS 8
    c legacy.mjs:33
    r legacy.mjs:100
    pick index-CRno7JSe.mjs:18
    pick index-CRno7JSe.mjs:10
    shareFromFiles AttachmentList.vue:228
    click AttachmentList.vue:1
    VueJS 4
    click NcButton.mjs:199
    VueJS 33
main.js:56:9

I tested this with both Firefox and Chromium on Fedora Linux 40.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a card
  2. Go to ‘attachments‘
  3. Press ‘share from files‘

Expected behavior
The file picker opens just fine.

Screenshots
afbeelding

Client details:

  • OS: Fedora Linux 40
  • Browser: Firefox 125.0.3, Chromium 124
  • Device: Desktop
Server details

Operating system: Fedora Linux 39

Web server: Apache/2.4.59 (Fedora Linux)

Database: mariadb Ver 15.1 Distrib 10.5.23-MariaDB, for Linux (x86_64) using EditLine wrapper

PHP version: 8.3

Nextcloud version: 29.0.1

Where did you install Nextcloud from: Archive

Signing status: No errors have been found.

List of activated apps:

Enabled:             
  - activity: 2.21.1
  - announcementcenter: 6.8.1
  - calendar: 4.7.4
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0             
  - contacts: 6.0.0           
  - contactsinteraction: 1.10.0
  - cospend: 1.6.1            
  - dashboard: 7.9.0  
  - dav: 1.30.1  
  - deck: 1.13.0         
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.0       
  - files_downloadlimit: 2.0.0                 
  - files_external: 1.21.0           
  - files_pdfviewer: 2.10.0               
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0           
  - files_trashbin: 1.19.0                    
  - files_versions: 1.22.0           
  - firstrunwizard: 2.18.0         
  - forms: 4.2.3                                 
  - guests: 3.1.0                              
  - logreader: 2.14.0                          
  - lookup_server_connector: 1.17.0                  
  - mail: 3.6.1                  
  - memories: 7.3.1                    
  - music: 1.11.0                  
  - nextcloud_announcements: 1.18.0    
  - notes: 4.10.0                     
  - notifications: 2.17.0                       
  - notify_push: 0.6.11    
  - oauth2: 1.17.0   
  - password_policy: 1.19.0                
  - phonetrack: 0.8.1                         
  - photos: 2.5.0
  - polls: 7.0.3                                                                                                                                                                                                                              
  - previewgenerator: 5.5.0    
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - qownnotesapi: 24.4.0
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - spreed: 19.0.1
  - support: 1.12.0
  - survey_client: 1.17.0
  - systemtags: 1.19.0
  - tables: 0.7.2
  - tasks: 0.16.0
  - text: 3.10.0
  - theming: 2.4.0
  - twofactor_admin: 4.5.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_totp: 11.0.0-dev
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_status: 1.9.0
  - viewer: 2.3.0
  - weather_status: 1.9.0
  - workflowengine: 2.11.0
Disabled:
  - admin_audit: 1.19.0
  - bruteforcesettings: 2.9.0 (installed 2.4.0)
  - checksum: 1.2.4 (installed 1.2.4)
  - collectives: 2.11.0 (installed 2.11.0)
  - encryption: 2.17.0
  - extract: 1.3.6 (installed 1.3.6)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - gpxpod: 5.0.18 (installed 5.0.18)
  - health: 2.2.2 (installed 2.2.2)
  - integration_gitlab: 1.0.19 (installed 1.0.19)
  - integration_google: 2.2.0 (installed 2.2.0)
  - integration_moodle: 1.0.2 (installed 1.0.2)
  - integration_whiteboard: 0.0.14 (installed 0.0.14)
  - maps: 1.4.0 (installed 1.4.0)
  - metadata: 0.19.0 (installed 0.19.0)
  - news: 24.0.0 (installed 24.0.0)
  - onlyoffice: 9.2.0 (installed 9.2.0)
  - recognize: 6.1.1 (installed 6.1.1)
  - socialsharing_email: 3.1.0 (installed 3.1.0)
  - suspicious_login: 7.0.0
  - user_ldap: 1.20.0
  - user_migration: 5.0.0 (installed 5.0.0)
  - workflow_script: 1.13.1 (installed 1.13.1)

Nextcloud configuration:

{                               
    "system": {                     
        "instanceid": "***REMOVED SENSITIVE VALUE***", 
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",                        
            "***REMOVED SENSITIVE VALUE***",
            "127.0.0.1"                                  
        ],                                                                                                             
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "29.0.1.1",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",                       
        "dbtableprefix": "oc_",                   
        "default_language": "en_GB", 
        "mysql.utf8mb4": true,          
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "enabledPreviewProviders": [
            "OC\\Preview\\BMP",
            "OC\\Preview\\GIF",                                                                                        
            "OC\\Preview\\JPEG",           
            "OC\\Preview\\MarkDown",                                                                                   
            "OC\\Preview\\MP3",                     
            "OC\\Preview\\PNG",                       
            "OC\\Preview\\TXT",
            "OC\\Preview\\XBitmap",     
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\Krita",       
            "OC\\Preview\\HEIC",
            "OC\\Preview\\TIFF",
            "OC\\Preview\\Movie",
            "OC\\Preview\\MKV",                                                                                                                                                                                                               
            "OC\\Preview\\MP4",                                           
            "OC\\Preview\\AVI",        
            "OC\\Preview\\Image"      
        ],                                      
        "default_phone_region": "DE",
        "installed": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",       
        "redis": {                                                                                                                                                                                                                            
            "host": "***REMOVED SENSITIVE VALUE***",                                                                                                                                                                                          
            "port": "0"                                                                                                
        },                                                 
        "htaccess.RewriteBase": "\/",                                                                                                                                                                                                         
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",                                                                                                                                                                                 
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "ssl",                       
        "mail_smtpauthtype": "LOGIN",             
        "mail_smtpauth": 1, 
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",     
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",                                                          
        "maintenance": false,                            
        "theme": "",      
        "loglevel": 1,        
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",                                                             
        "logfilemode": 384,                       
        "lost_password_link": "disabled",         
        "updater.release.channel": "stable",
        "trashbin_retention_obligation": "60, 61",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": [   
            "guest_app",                              
            "Testing"               
        ],                     
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",                                                            
        "memories.exiftool_no_local": true,
        "memories.vod.path": "\/var\/www\/nextcloud-subvolume\/nextcloud\/apps\/memories\/bin-ext\/go-vod-amd64",      
        "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg",
        "memories.vod.ffprobe": "\/usr\/bin\/ffprobe",
        "defaultapp": "",      
        "maintenance_window_start": "1",
        "memories.gis_type": 1,         
        "memories.db.triggers.fcu": true
    }                           
}

Are you using an external user-backend, if yes which one: No

Logs

Nextcloud log (data/nextcloud.log)

{
  "reqId": "bUyFbbNp24BYYhVcZMBK",
  "level": 3,
  "time": "2024-05-24T08:30:52+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "PHP",
  "method": "",
  "url": "--",
  "message": "Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter at /var/www/nextcloud-subvolume/nextcloud/apps/deck/lib/Service/ConfigService.php#234",
  "userAgent": "--",
  "version": "29.0.1.1",
  "data": {
    "app": "PHP"
  },
  "id": "665050469c34b"
}

No other logs with level info or higher related to deck.

Browser log

console-export-2024-5-25_22-23-21.txt
@joesch2
Copy link

joesch2 commented May 26, 2024 •
edited
Loading

I also observe the same behavior on my installation.
Nexctcloud: Version 28.0.6
Deck: Version 1.11.4
Browser: Firefox 126.0
Device: Desktop Win11

@slu-010101
Copy link

We are also affected by this issue.
Nextcloud 29.0.1
Firefox 126.0.1

@aliearly
Copy link

Same for us Nextcloud 29.0. All browsers are the same. Firefox, Chrome , Safari , Opera.

@mortee
Copy link

mortee commented May 30, 2024

A lot of "undefined" errors in Deck lately. Aside from attachments, when clicking away from editing card title, when trying to pick a board for linking to another card, etc. What's going on?

@elzody elzody self-assigned this May 31, 2024
@elzody elzody added the bug label May 31, 2024
@susnux
Copy link
Contributor

susnux commented Jun 1, 2024

You probably need to update the files library see also:
nextcloud-libraries/nextcloud-dialogs#1331

@susnux
Copy link
Contributor

susnux commented Jun 1, 2024

Yes there is a version issue between dialogs, files and webdav.
I recommend to update to latest v5.x of dialogs on stable 28 and 29 (and main).

@newkindofworld
Copy link

Yes there is a version issue between dialogs, files and webdav. I recommend to update to latest v5.x of dialogs on stable 28 and 29 (and main).

Same issue here running Nextcloud 29.0.1, how to update dialogs to v5.x, or update other libraries ?

@susnux
Copy link
Contributor

susnux commented Jun 2, 2024

Needs to be done here in the deck app.

@leclou69
Copy link

leclou69 commented Jun 2, 2024

Seems to be the same as here: #5822

@susnux susnux mentioned this issue Jun 3, 2024
Merged
4 tasks
@st3iny st3iny mentioned this issue Jun 4, 2024
Closed
@elzody elzody linked a pull request Jun 26, 2024 that will close this issue
[stable29] fix: Adjust dependencies to fix filepicker #6038
Merged
4 tasks
@elzody elzody mentioned this issue Jun 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elzody elzody

Labels
bug
Projects
None yet
Milestone
No milestone
9 participants
@mortee @susnux @newkindofworld @slu-010101 @leclou69 @joesch2 @elzody @PatrickJosh @aliearly