Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css guidelines summary #333

Closed
skjnldsv opened this issue Jan 26, 2017 · 10 comments
Closed

Css guidelines summary #333

skjnldsv opened this issue Jan 26, 2017 · 10 comments

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jan 26, 2017

https://docs.nextcloud.com/server/12/developer_manual/app/css.html
This is a list of what we need to do to update it

  1. Rebuild icons list
  2. Add popover explanations: [styleguide] Popover menu server#2798
    • Arrow position (padding right)
    • Popover types: text only, icon only, text+icon, paragraph
    • Popover alignment: right, center, left
  3. Button design
    • text only, icon only, icon+text
  4. Header menu
    • menu class
    • arrow position
  5. App-navigation
    • Need active class on li for blue shadow
    • ul must be direct children of #app-navigation
    • with-counter with-menu with-icon not needed anymore
    • no need for the svg class
    • the icon class must have icon- in it to have the auto padding
    • rules about padding and margin of li elements
    • maximum nested menu is 1
    • icon menu custom in app-navigation-entry-utils
    • max icon h/w
    • bullet class
    • loading icon class to menu
    • encourage users to use the "deleted X" string
    • ability to set class in files nav -> pinned class
@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@jancborchardt
Copy link
Member

Popover types: icon only

This should not exist. ;)

@jancborchardt
Copy link
Member

cc @eppfel on this one

@eppfel eppfel self-assigned this Feb 15, 2017
@jancborchardt
Copy link
Member

@skjnldsv any update here? :)

@eppfel eppfel assigned skjnldsv and unassigned eppfel and skjnldsv Apr 27, 2017
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2017

Okay, I will soon finally have the guts to attack this! :)
Wish me luck! :D

@MorrisJobke
Copy link
Member

cc @Espina2 because we talked about this at the conf again and it was unclear who wants to look into this ;)

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2017

I would be glad to work with someone on this. I think this is one of the biggest issue we have in our dev manual, and it leads many apps to inconsistency amongst them! :)

@jancborchardt
Copy link
Member

@skjnldsv I'm down to contribute. :) We should also use this to standardize the Mail/Contacts column layout, using the classes from the Contacts app.

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2017

I'm also on it! ^^'
Let me finish polishing all the scss on server, adding the latest classes, backporting and we'll be good to go on the docs! 🙈 🙌

@Espina2
Copy link

Espina2 commented Sep 7, 2017

@MorrisJobke I will be completelly stuck in this month, so no time to help. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants