Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sync conflicts more gracefully #2582

Closed
ChristophWurst opened this issue Jan 30, 2020 · 0 comments · Fixed by #2616
Closed

Handle sync conflicts more gracefully #2582

ChristophWurst opened this issue Jan 30, 2020 · 0 comments · Fixed by #2616
Assignees
Milestone

Comments

@ChristophWurst
Copy link
Member

Expected behavior

#2064 correctly catches concurrent sync attempts of the same mailbox. Running into this is expected and not an error.

Actual behavior

This gets logged to nextcloud.log, sent to Sentry and might pop up as error for the user.

Mail app

Mail app version:

One with #2064.


Solution: I think we could just ignore the request. Or send again later. We just have to be careful not to send too many requests. Exponential back-off could help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant