From bf5b9f4d500cd0d9973a9bff9fdb86c78066e6a4 Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 15:00:16 +0200
Subject: [PATCH 1/9] Force menu for shared album content actions

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 src/views/SharedAlbumContent.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/SharedAlbumContent.vue b/src/views/SharedAlbumContent.vue
index 8d5d29e2f..b9ebee4d2 100644
--- a/src/views/SharedAlbumContent.vue
+++ b/src/views/SharedAlbumContent.vue
@@ -54,7 +54,7 @@
 						</template>
 					</NcButton>
 
-					<NcActions :aria-label="t('photos', 'Open actions menu')">
+					<NcActions :force-menu="true" :aria-label="t('photos', 'Open actions menu')">
 						<ActionDownload v-if="albumFileIds.length > 0"
 							:selected-file-ids="albumFileIds"
 							:title="t('photos', 'Download all files in album')">

From 7060b482e957522bf975001e2c41efb442767d59 Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 15:00:37 +0200
Subject: [PATCH 2/9] Correctly redirect on shared album deletion

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 src/views/SharedAlbumContent.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/views/SharedAlbumContent.vue b/src/views/SharedAlbumContent.vue
index b9ebee4d2..32613f005 100644
--- a/src/views/SharedAlbumContent.vue
+++ b/src/views/SharedAlbumContent.vue
@@ -290,6 +290,7 @@ export default {
 
 		async handleDeleteAlbum() {
 			await this.deleteSharedAlbum({ albumName: this.albumName })
+			this.$router.push('/sharedalbums')
 		},
 	},
 }

From bde9865ce18e732d1de93048689e461ed9002d91 Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 15:00:53 +0200
Subject: [PATCH 3/9] Add header to SharedAlbums

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 src/views/Albums.vue       |  1 -
 src/views/SharedAlbums.vue | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/views/Albums.vue b/src/views/Albums.vue
index 2ce1131cf..34fbd4c1b 100644
--- a/src/views/Albums.vue
+++ b/src/views/Albums.vue
@@ -31,7 +31,6 @@
 				:title="t('photos', 'Albums')"
 				:root-title="t('photos', 'Albums')"
 				@refresh="onRefresh">
-				<slot name="header" />
 				<NcButton :aria-label="t('photos', 'Create a new album.')"
 					@click="showAlbumCreationForm = true">
 					<template #icon>
diff --git a/src/views/SharedAlbums.vue b/src/views/SharedAlbums.vue
index 5600322a3..09250bb50 100644
--- a/src/views/SharedAlbums.vue
+++ b/src/views/SharedAlbums.vue
@@ -26,6 +26,13 @@
 		:collection-root="t('photos', 'Shared albums')"
 		:error="errorFetchingAlbums"
 		class="albums-list">
+		<HeaderNavigation key="navigation"
+			slot="header"
+			:loading="loadingAlbums"
+			:title="t('photos', 'Shared albums')"
+			:root-title="t('photos', 'Shared albums')"
+			@refresh="onRefresh" />
+
 		<CollectionCover :key="collection.basename"
 			slot-scope="{collection}"
 			:link="`/sharedalbums/${collection.basename}`"
@@ -55,6 +62,7 @@ import { NcEmptyContent } from '@nextcloud/vue'
 import FetchSharedAlbumsMixin from '../mixins/FetchSharedAlbumsMixin.js'
 import CollectionsList from '../components/Collection/CollectionsList.vue'
 import CollectionCover from '../components/Collection/CollectionCover.vue'
+import HeaderNavigation from '../components/HeaderNavigation.vue'
 
 export default {
 	name: 'SharedAlbums',
@@ -63,6 +71,7 @@ export default {
 		NcEmptyContent,
 		CollectionsList,
 		CollectionCover,
+		HeaderNavigation,
 	},
 
 	filters: {
@@ -81,6 +90,12 @@ export default {
 	mixins: [
 		FetchSharedAlbumsMixin,
 	],
+
+	methods: {
+		onRefresh() {
+			this.fetchAlbums()
+		},
+	},
 }
 </script>
 <style lang="scss" scoped>

From 93e011436c5bd484c36385ace49c65a1d7cee43f Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 15:38:07 +0200
Subject: [PATCH 4/9] Add EmptyContent in CollaboratorSelectionForm

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 .../Albums/CollaboratorsSelectionForm.vue       | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/components/Albums/CollaboratorsSelectionForm.vue b/src/components/Albums/CollaboratorsSelectionForm.vue
index f1f46734b..cd73d3992 100644
--- a/src/components/Albums/CollaboratorsSelectionForm.vue
+++ b/src/components/Albums/CollaboratorsSelectionForm.vue
@@ -45,7 +45,7 @@
 					<NcLoadingIcon v-if="loadingCollaborators" />
 				</label>
 
-				<ul :id="`manage-collaborators__form__list-${randomId}`" class="manage-collaborators__form__list">
+				<ul v-if="searchResults.length !== 0" :id="`manage-collaborators__form__list-${randomId}`" class="manage-collaborators__form__list">
 					<li v-for="result of searchResults" :key="result.key">
 						<a>
 							<NcListItemIcon :id="availableCollaborators[result.key].id"
@@ -58,6 +58,12 @@
 						</a>
 					</li>
 				</ul>
+				<NcEmptyContent v-else
+					key="emptycontent"
+					class="manage-collaborators__form__list--empty"
+					:title="t('photos', 'No collaborators available')">
+					<AccountGroup slot="icon" />
+				</NcEmptyContent>
 			</NcPopover>
 		</form>
 
@@ -116,13 +122,14 @@
 <script>
 import Magnify from 'vue-material-design-icons/Magnify'
 import Close from 'vue-material-design-icons/Close'
+import AccountGroup from 'vue-material-design-icons/AccountGroup'
 import Earth from 'vue-material-design-icons/Earth'
 
 import axios from '@nextcloud/axios'
 import { showError } from '@nextcloud/dialogs'
 import { getCurrentUser } from '@nextcloud/auth'
 import { generateOcsUrl } from '@nextcloud/router'
-import { NcButton, NcListItemIcon, NcLoadingIcon, NcPopover, NcTextField } from '@nextcloud/vue'
+import { NcButton, NcListItemIcon, NcLoadingIcon, NcPopover, NcTextField, NcEmptyContent } from '@nextcloud/vue'
 
 import logger from '../../services/logger.js'
 
@@ -140,12 +147,14 @@ export default {
 	components: {
 		Magnify,
 		Close,
+		AccountGroup,
 		Earth,
 		NcLoadingIcon,
 		NcButton,
 		NcListItemIcon,
 		NcTextField,
 		NcPopover,
+		NcEmptyContent,
 	},
 
 	props: {
@@ -355,6 +364,10 @@ export default {
 					background: var(--color-background-dark);
 				}
 			}
+
+			&--empty {
+				margin: 100px 0;
+			}
 		}
 	}
 

From d51b070d38cf30509ee41c8b5ac26d039405fb21 Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 16:06:25 +0200
Subject: [PATCH 5/9] Add tests to remove collaborator

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 cypress/e2e/shared_albums.cy.js                      | 5 +++--
 cypress/support/commands.js                          | 9 +++++++--
 src/components/Albums/CollaboratorsSelectionForm.vue | 3 +--
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/cypress/e2e/shared_albums.cy.js b/cypress/e2e/shared_albums.cy.js
index 9619cfdfd..21b82653e 100644
--- a/cypress/e2e/shared_albums.cy.js
+++ b/cypress/e2e/shared_albums.cy.js
@@ -128,11 +128,12 @@ describe('Manage shared albums', () => {
     cy.removeSharedAlbums()
   })
 
-  xit('Remove collaborator from an album', () => {
-    cy.get('[data-test="media"]').should('have.length', 4)
+  it('Remove collaborator from an album', () => {
+    cy.get('ul.collections__list li').should('have.length', 4)
 
     cy.logout()
     cy.login(randUser, 'password')
+    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos`)
     cy.goToAlbum('shared_album_test4')
     cy.removeCollaborators([randUser2])
     cy.logout()
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
index d1eed57cc..e81bba94c 100644
--- a/cypress/support/commands.js
+++ b/cypress/support/commands.js
@@ -232,8 +232,13 @@ Cypress.Commands.add('addCollaborators', collaborators => {
 Cypress.Commands.add('removeCollaborators', collaborators => {
 	cy.get('[aria-label="Manage collaborators for this album"]').click()
 	collaborators.forEach((collaborator) => {
-		cy.get('[aria-label="Search for collaborators"').type(collaborator)
-		cy.contains(collaborator).click()
+		cy.get('.manage-collaborators')
+			.within(() => {
+				cy.contains(collaborator)
+					.parentsUntil('ul')
+					.get(`[aria-label="Remove ${collaborator} from the collaborators list"]`)
+					.click()
+			})
 	})
 	cy.contains('Save').click()
 })
diff --git a/src/components/Albums/CollaboratorsSelectionForm.vue b/src/components/Albums/CollaboratorsSelectionForm.vue
index cd73d3992..9cc02afea 100644
--- a/src/components/Albums/CollaboratorsSelectionForm.vue
+++ b/src/components/Albums/CollaboratorsSelectionForm.vue
@@ -73,8 +73,7 @@
 				class="manage-collaborators__selection__item">
 				<NcListItemIcon :id="availableCollaborators[collaboratorKey].id"
 					:title="availableCollaborators[collaboratorKey].id"
-					:display-name="availableCollaborators[collaboratorKey].label"
-					:aria-label="t('photos', 'Remove {collaboratorLabel} from the collaborators list', {collaboratorLabel: availableCollaborators[collaboratorKey].label})">
+					:display-name="availableCollaborators[collaboratorKey].label">
 					<NcButton type="tertiary"
 						:aria-label="t('photos', 'Remove {collaboratorLabel} from the collaborators list', {collaboratorLabel: availableCollaborators[collaboratorKey].label})"
 						@click="unselectEntity(collaboratorKey)">

From fe935111122800608f12bafedefd70688c7095bd Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 16:06:59 +0200
Subject: [PATCH 6/9] Add test to delete shared album

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 cypress/e2e/shared_albums.cy.js | 2 +-
 cypress/support/commands.js     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cypress/e2e/shared_albums.cy.js b/cypress/e2e/shared_albums.cy.js
index 21b82653e..19802a723 100644
--- a/cypress/e2e/shared_albums.cy.js
+++ b/cypress/e2e/shared_albums.cy.js
@@ -123,7 +123,7 @@ describe('Manage shared albums', () => {
     cy.get('[data-test="media"]').should('have.length', 0)
   })
 
-  xit('Remove shared album', () => {
+  it('Remove shared album', () => {
     cy.goToSharedAlbum('shared_album_test3')
     cy.removeSharedAlbums()
   })
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
index e81bba94c..aa4828f3a 100644
--- a/cypress/support/commands.js
+++ b/cypress/support/commands.js
@@ -243,7 +243,7 @@ Cypress.Commands.add('removeCollaborators', collaborators => {
 	cy.contains('Save').click()
 })
 
-Cypress.Commands.add('removeSharedAlbums', collaborators => {
+Cypress.Commands.add('removeSharedAlbums', () => {
 	cy.get('[aria-label="Open actions menu"]').click()
-	cy.contains("Remove selection from album").click()
+	cy.contains("Delete album").click()
 })

From 66813e6ae8cb5408b93a21862615bc20041f875c Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 16:32:49 +0200
Subject: [PATCH 7/9] Add tests to adit album's name

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 cypress/e2e/albums.cy.js   | 32 ++++++++++++++++++++++++++++++++
 src/views/AlbumContent.vue |  7 +------
 2 files changed, 33 insertions(+), 6 deletions(-)

diff --git a/cypress/e2e/albums.cy.js b/cypress/e2e/albums.cy.js
index 53bc32b7b..044776f82 100644
--- a/cypress/e2e/albums.cy.js
+++ b/cypress/e2e/albums.cy.js
@@ -99,4 +99,36 @@ describe('Manage albums', () => {
     cy.downloadSelection()
     cy.unselectMedia([1, 2])
   })
+
+  it('Edit an album\'s name', () => {
+    cy.get('[aria-label="Open actions menu"]').click()
+    cy.contains('Edit album details').click()
+    cy.get('form [name="name"]').clear().type("New name")
+    cy.contains('Save').click()
+
+    cy.reload()
+
+    cy.contains('New name')
+
+    cy.get('[aria-label="Open actions menu"]').click()
+    cy.contains('Edit album details').click()
+    cy.get('form [name="name"]').clear().type("albums_test")
+    cy.contains('Save').click()
+  })
+
+  it('Edit an album\'s location', () => {
+    cy.get('[aria-label="Open actions menu"]').click()
+    cy.contains('Edit album details').click()
+    cy.get('form [name="location"]').clear().type("New location")
+    cy.contains('Save').click()
+
+    cy.reload()
+
+    cy.contains('New location')
+
+    cy.get('[aria-label="Open actions menu"]').click()
+    cy.contains('Edit album details').click()
+    cy.get('form [name="location"]').clear()
+    cy.contains('Save').click()
+  })
 })
diff --git a/src/views/AlbumContent.vue b/src/views/AlbumContent.vue
index 43270956b..e1836d8c2 100644
--- a/src/views/AlbumContent.vue
+++ b/src/views/AlbumContent.vue
@@ -379,12 +379,7 @@ export default {
 			this.showEditAlbumForm = false
 
 			if (this.album.basename !== album.basename) {
-				this.$router.push({
-					name: 'albums',
-					params: {
-						path: album.basename,
-					},
-				})
+				this.$router.push(`/albums/${album.basename}`)
 			}
 		},
 

From 90c90cd2e01c27c54294d9501611af3b7f8de65c Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 17:06:11 +0200
Subject: [PATCH 8/9] Refactor shared albums tests

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 cypress/e2e/shared_albums.cy.js | 200 +++++++++++++++++---------------
 1 file changed, 109 insertions(+), 91 deletions(-)

diff --git a/cypress/e2e/shared_albums.cy.js b/cypress/e2e/shared_albums.cy.js
index 19802a723..ea00fe4ff 100644
--- a/cypress/e2e/shared_albums.cy.js
+++ b/cypress/e2e/shared_albums.cy.js
@@ -20,8 +20,10 @@
  *
  */
 import { randHash } from '../utils'
+
 const randUser = randHash()
 const randUser2 = randHash()
+const randUser3 = randHash()
 
 const resizeObserverLoopErrRe = /^[^(ResizeObserver loop limit exceeded)]/
 Cypress.on('uncaught:exception', (err) => {
@@ -34,113 +36,129 @@ Cypress.on('uncaught:exception', (err) => {
 describe('Manage shared albums', () => {
   before(() => {
     cy.logout()
+
     cy.nextcloudCreateUser(randUser, 'password')
     cy.nextcloudCreateUser(randUser2, 'password')
-
-    cy.login(randUser, 'password')
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
-    cy.createAnAlbumFromAlbums('shared_album_test1')
-    cy.addCollaborators([randUser2])
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
-    cy.createAnAlbumFromAlbums('shared_album_test2')
-    cy.addCollaborators([randUser2])
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
-    cy.createAnAlbumFromAlbums('shared_album_test3')
-    cy.addCollaborators([randUser2])
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
-    cy.createAnAlbumFromAlbums('shared_album_test4')
-    cy.addCollaborators([randUser2])
-    cy.logout()
+    cy.nextcloudCreateUser(randUser3, 'password')
 
     cy.login(randUser2, 'password')
     cy.uploadTestMedia()
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/sharedalbums`)
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.addFilesToAlbumFromAlbum('shared_album_test2', [0, 1, 2])
-
-    // wait a bit for things to be settled
-    cy.wait(1000)
+    cy.logout()
   })
 
   beforeEach(() => {
+    cy.logout()
+    cy.login(randUser2, 'password')
     cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/sharedalbums`)
   })
 
-  it('Add and remove a file to a shared album from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test1')
-    cy.get('[data-test="media"]').should('have.length', 0)
-    cy.addFilesToAlbumFromAlbum('shared_album_test1', [0])
-    cy.get('[data-test="media"]').should('have.length', 1)
-    cy.selectMedia([0])
-    cy.removeSelectionFromAlbum()
-    cy.get('[data-test="media"]').should('have.length', 0)
-  })
-
-  it('Add and remove multiple files to a shared album from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test1')
-    cy.get('[data-test="media"]').should('have.length', 0)
-    cy.addFilesToAlbumFromAlbum('shared_album_test1', [1, 2])
-    cy.get('[data-test="media"]').should('have.length', 2)
-    cy.selectMedia([0, 1])
-    cy.removeSelectionFromAlbum()
-    cy.get('[data-test="media"]').should('have.length', 0)
-  })
-
-  it('Download a file from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.selectMedia([0])
-    cy.downloadSelection()
-    cy.unselectMedia([0])
+  context('Adding and removing files in a shared album', () => {
+    before(() => {
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test1')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+    })
+
+    it('Add and remove a file to a shared album from a shared album', () => {
+      cy.goToSharedAlbum('shared_album_test1')
+      cy.get('[data-test="media"]').should('have.length', 0)
+      cy.addFilesToAlbumFromAlbum('shared_album_test1', [0])
+      cy.get('[data-test="media"]').should('have.length', 1)
+      cy.selectMedia([0])
+      cy.removeSelectionFromAlbum()
+      cy.get('[data-test="media"]').should('have.length', 0)
+    })
+
+    it('Add and remove multiple files to a shared album from a shared album', () => {
+      cy.goToSharedAlbum('shared_album_test1')
+      cy.get('[data-test="media"]').should('have.length', 0)
+      cy.addFilesToAlbumFromAlbum('shared_album_test1', [1, 2])
+      cy.get('[data-test="media"]').should('have.length', 2)
+      cy.selectMedia([0, 1])
+      cy.removeSelectionFromAlbum()
+      cy.get('[data-test="media"]').should('have.length', 0)
+    })
   })
 
-  it('Download multiple files from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.selectMedia([1, 2])
-    cy.downloadSelection()
-    cy.unselectMedia([1, 2])
+  context('Download files from a shared album', () => {
+    before(() => {
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test2')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+
+      cy.login(randUser2, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/sharedalbums`)
+      cy.goToSharedAlbum('shared_album_test2')
+      cy.addFilesToAlbumFromAlbum('shared_album_test2', [0, 1, 2])
+      cy.logout()
+    })
+
+    it('Download a file from a shared album', () => {
+      cy.goToSharedAlbum('shared_album_test2')
+      cy.selectMedia([0])
+      cy.downloadSelection()
+      cy.unselectMedia([0])
+    })
+
+    it('Download multiple files from a shared album', () => {
+      cy.goToSharedAlbum('shared_album_test2')
+      cy.selectMedia([1, 2])
+      cy.downloadSelection()
+      cy.unselectMedia([1, 2])
+    })
+
+    it('Download all files from a shared album', () => {
+      cy.goToSharedAlbum('shared_album_test2')
+      cy.downloadAllFiles()
+    })
   })
 
-  it('Download all files from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.downloadAllFiles()
+  context('Delete a received shared album', () => {
+    before(() => {
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test3')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+    })
+
+    it('Remove shared album', () => {
+      cy.goToSharedAlbum('shared_album_test3')
+      cy.removeSharedAlbums()
+    })
   })
 
-  it('Remove a file from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.get('[data-test="media"]').should('have.length', 3)
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.selectMedia([0])
-    cy.removeSelectionFromAlbum()
-    cy.get('[data-test="media"]').should('have.length', 2)
-  })
-
-  it('Remove multiple files from a shared album', () => {
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.get('[data-test="media"]').should('have.length', 2)
-    cy.goToSharedAlbum('shared_album_test2')
-    cy.selectMedia([0, 1])
-    cy.removeSelectionFromAlbum()
-    cy.get('[data-test="media"]').should('have.length', 0)
-  })
-
-  it('Remove shared album', () => {
-    cy.goToSharedAlbum('shared_album_test3')
-    cy.removeSharedAlbums()
-  })
-
-  it('Remove collaborator from an album', () => {
-    cy.get('ul.collections__list li').should('have.length', 4)
-
-    cy.logout()
-    cy.login(randUser, 'password')
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos`)
-    cy.goToAlbum('shared_album_test4')
-    cy.removeCollaborators([randUser2])
-    cy.logout()
-
-    cy.login(randUser2, 'password')
-    cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/sharedalbums`)
-
-    cy.get('ul.collections__list li').should('have.length', 3)
+  context('Remove a collaborator from an album', () => {
+    before(() => {
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test4')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+    })
+
+    it('Remove collaborator from an album', () => {
+      cy.get('ul.collections__list li').should('have.length', 4)
+
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos`)
+      cy.goToAlbum('shared_album_test4')
+      cy.removeCollaborators([randUser2])
+      cy.logout()
+
+      cy.login(randUser2, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/sharedalbums`)
+
+      cy.get('ul.collections__list li').should('have.length', 3)
+    })
   })
 })
\ No newline at end of file

From cdf57cbf608e6155b2e7e19edd98133b7602044c Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Fri, 16 Sep 2022 17:17:17 +0200
Subject: [PATCH 9/9] Support  receiving two albums with the same names

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 cypress/e2e/shared_albums.cy.js | 25 +++++++++++++++++++++++++
 lib/Album/AlbumMapper.php       |  6 +++---
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/cypress/e2e/shared_albums.cy.js b/cypress/e2e/shared_albums.cy.js
index ea00fe4ff..283974bad 100644
--- a/cypress/e2e/shared_albums.cy.js
+++ b/cypress/e2e/shared_albums.cy.js
@@ -161,4 +161,29 @@ describe('Manage shared albums', () => {
       cy.get('ul.collections__list li').should('have.length', 3)
     })
   })
+
+  context('Two shared albums with the same name', () => {
+    before(() => {
+      cy.logout()
+      cy.login(randUser, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test5')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+
+      cy.login(randUser3, 'password')
+      cy.visit(`${Cypress.env('baseUrl')}/index.php/apps/photos/albums`)
+      cy.createAnAlbumFromAlbums('shared_album_test5')
+      cy.addCollaborators([randUser2])
+      cy.logout()
+    })
+
+
+    it('It should display two shared albums', () => {
+      cy.get('ul.collections__list li')
+        .contains(`shared_album_test5 (${randUser})`)
+      cy.get('ul.collections__list li')
+        .contains(`shared_album_test5 (${randUser3})`)
+    })
+  })
 })
\ No newline at end of file
diff --git a/lib/Album/AlbumMapper.php b/lib/Album/AlbumMapper.php
index d3e882046..827b8c802 100644
--- a/lib/Album/AlbumMapper.php
+++ b/lib/Album/AlbumMapper.php
@@ -364,11 +364,11 @@ public function getSharedAlbumsForCollaboratorWithFiles(string $collaboratorId,
 			if ($row['fileid']) {
 				$mimeId = $row['mimetype'];
 				$mimeType = $this->mimeTypeLoader->getMimetypeById($mimeId);
-				$filesByAlbum[$albumId][] = new AlbumFile((int)$row['fileid'], $row['file_name'], $mimeType, (int)$row['size'], (int)$row['mtime'], $row['etag'], (int)$row['added'], $row['owner']);
+				$filesByAlbum[$albumId][] = new AlbumFile((int)$row['fileid'], $row['album_name'].' ('.$row['album_user'].')', $mimeType, (int)$row['size'], (int)$row['mtime'], $row['etag'], (int)$row['added'], $row['owner']);
 			}
 
 			if (!isset($albumsById[$albumId])) {
-				$albumsById[$albumId] = new AlbumInfo($albumId, $row['album_user'], $row['album_name'], $row['location'], (int)$row['created'], (int)$row['last_added_photo']);
+				$albumsById[$albumId] = new AlbumInfo($albumId, $row['album_user'], $row['album_name'].' ('.$row['album_user'].')', $row['location'], (int)$row['created'], (int)$row['last_added_photo']);
 			}
 		}
 
@@ -419,7 +419,7 @@ public function getAlbumForCollaboratorIdAndFileId(string $collaboratorId, int $
 			return new AlbumInfo(
 				(int)$row['album_id'],
 				$row['user'],
-				$row['name'],
+				$row['name'].' ('.$row['user'].')',
 				$row['location'],
 				(int)$row['created'],
 				(int)$row['last_added_photo']