From b3f345f1b9e74256de8fa91600e06b167445fdbf Mon Sep 17 00:00:00 2001 From: Alexander Piskun <13381981+bigcat88@users.noreply.github.com> Date: Sat, 22 Jul 2023 13:18:43 +0300 Subject: [PATCH] to return correct code when group not found Signed-off-by: Alexander Piskun --- apps/provisioning_api/lib/Controller/GroupsController.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/provisioning_api/lib/Controller/GroupsController.php b/apps/provisioning_api/lib/Controller/GroupsController.php index e7e2a666b7bb4..46de5395a6560 100644 --- a/apps/provisioning_api/lib/Controller/GroupsController.php +++ b/apps/provisioning_api/lib/Controller/GroupsController.php @@ -271,6 +271,9 @@ public function updateGroup(string $groupId, string $key, string $value): DataRe if ($key === 'displayname') { $group = $this->groupManager->get($groupId); + if ($group === null) { + throw new OCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND); + } if ($group->setDisplayName($value)) { return new DataResponse(); }