Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming admin settings doesn't show set values #1032

Closed
juliushaertl opened this issue Aug 24, 2016 · 3 comments
Closed

Theming admin settings doesn't show set values #1032

juliushaertl opened this issue Aug 24, 2016 · 3 comments
Labels
bug feature: theming high

Comments

@juliushaertl
Copy link
Member

juliushaertl commented Aug 24, 2016 •
edited
Loading

The theming app admin settings doesn't show set values.

Steps to reproduce:

  1. Set a new name/slogan/..
  2. Wait for it to be saved
  3. Reload the admin page
  4. Changes are not shown

This bug was introduced by #1006, as the Admin settings will get an OC_Defaults instance instead of ThemingDefaults even when the app is already enabled.
@juliushaertl
Copy link
Member Author

cc @blizzz @rullzer @nickvergessen

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

O joy... I'll dive into this.

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

Ah it gets casted down it seems...

@rullzer rullzer mentioned this issue Aug 24, 2016
Merged
@blizzz blizzz added the high label Aug 24, 2016
@nextcloud-bot nextcloud-bot mentioned this issue Jul 3, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature: theming high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rullzer @blizzz @juliushaertl