NC14 - Favorites shown as blanks

[timmersr]

After upgrading to NC14 some favorites are displayed as blanks.
Even after removing them as favorite and re-adding, the issue continues to exist.

Steps to reproduce

1. Upgrade to NC14
2. Display favorites, some (possibily) show as blanks. Click on a blank favorite to go to the related folder.
3. Remove as favorite, and re-add as favorite.

Expected behaviour

All favorites should display correctly.

Actual behaviour

Some favorites remain displayed as blanks

Server configuration

VM

Operating system:
Ubuntu 16.04.5 LTS

Web server:
Apache2

Database:

PHP version:
7.0.30-1

Nextcloud version: (see Nextcloud admin page)
14.0.0.19

Updated from an older Nextcloud/ownCloud or fresh install:
Updated from 13.0.6

Where did you install Nextcloud from:
Webinstaller

Signing status:

Signing status

Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.
No errors have been found.
</details>

**List of activated apps:**
Enabled:
  - accessibility: 1.0.1
  - activity: 2.7.0
  - admin_audit: 1.4.0
  - calendar: 1.6.2
  - cloud_federation_api: 0.0.1
  - comments: 1.4.0
  - dav: 1.6.0
  - federatedfilesharing: 1.4.0
  - federation: 1.4.0
  - files: 1.9.0
  - files_pdfviewer: 1.3.2
  - files_sharing: 1.6.2
  - files_texteditor: 2.6.0
  - files_trashbin: 1.4.1
  - files_versions: 1.7.1
  - files_videoplayer: 1.3.0
  - firstrunwizard: 2.3.0
  - gallery: 18.1.0
  - impersonate: 1.1.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.2.0
  - nextcloud_announcements: 1.3.0
  - notifications: 2.2.1
  - oauth2: 1.2.1
  - password_policy: 1.4.0
  - provisioning_api: 1.4.0
  - richdocuments: 2.0.12
  - serverinfo: 1.4.0
  - sharebymail: 1.4.0
  - support: 1.0.0
  - systemtags: 1.4.0
  - theming: 1.5.0
  - twofactor_backupcodes: 1.3.1
  - twofactor_totp: 1.5.0
  - unsplash: 1.1.1
  - updatenotification: 1.4.1
  - workflowengine: 1.4.0
Disabled:
  - encryption
  - files_accesscontrol
  - files_downloadactivity
  - files_external
  - survey_client
  - user_external
  - user_ldap


**Nextcloud configuration:**
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "14.0.0.19",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "UTC",
        "installed": true,
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "trashbin_retention_obligation": "auto",
        "0": 93,
        "loglevel": 0,
        "updater.release.channel": "stable",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "filelocking.enabled": "true",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}
**Are you using external storage, if yes which one:** local/smb/sftp/...
no

**Are you using encryption:** yes/no
no

**Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/...
no



### Client configuration
**Browser:**
Firefox 62.0 (64-bits)

**Operating system:**
Windows 10 Pro (1803)

### Logs
#### Web server error log
(nothing)

#### Nextcloud log (data/nextcloud.log)
(no errors)

#### Browser log
<details>

[timmersr]

Also noticed that the Excel file marked as favorite is not shown. Is it supposed to be displayed on the left side?

[nextcloud-bot]

GitMate.io thinks possibly related issues are #10612 (WebDAV in NC14), #2193 (Files: show favorites column in Shared views as well), #6361 (Show checkbox where the favorite star is now), #4697 (Files: show favorites column in Recent view as well), and #5408 (Files: not all shares are shown if folder is marked as favorite).

[grisumedia]

It looks to me like the folders owned and shared by other users are displayed as blank and my own folders are displayed correctly, even if they are shared with other users.

[weeman1337]

I can reproduce this issue. Thanks for the report. I'll have a look.

[MorrisJobke]

Fixed by #11259