Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log for admin setting changes #12629

Open
MorrisJobke opened this issue Nov 23, 2018 · 4 comments
Open

Audit log for admin setting changes #12629

MorrisJobke opened this issue Nov 23, 2018 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: admin audit

Comments

@MorrisJobke
Copy link
Member

It would be useful to log when which administrator changed a setting. For example the "password policy": when did a change to "1 character is required only" was done.

Would a simple "listen to all config changes" hook work here? Or is this overkill?

cc @nickvergessen @blizzz @rullzer

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #1261 (force password change for all users by admin), #3777 (Change of user passwords by admin fails), #8778 (Log in as user as Admin), #9191 (Change own quota as group admin), and #5399 (Group admin cannot change settings in user management).

@nickvergessen
Copy link
Member

I think we should do specific hooks in the password_policy app

@blizzz
Copy link
Member

blizzz commented Nov 23, 2018

Would a simple "listen to all config changes" hook work here? Or is this overkill?

Could be overkill, when background jobs set markers. Could be filtered out on CLI, but perhaps not so easily on Ajax.

Changes on the config.php would not be caught when they are done manually in the file. Leaves appconfig. User preferences is again difficult.

Firing dedicated hooks is more fine-grained, but also more error prone (as in easy to be forgotten) on changes and new features.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 17, 2019
@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

I suppose this issue is still valid? If not, please close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: admin audit
Projects
None yet
Development

No branches or pull requests

6 participants