Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Styles slightly broken on login flow for older Android Webview versions #37123

Open
5 of 9 tasks
AlvaroBrey opened this issue Mar 8, 2023 · 3 comments
Open
5 of 9 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback 26-feedback bug design Design, UI, UX, etc. feature: authentication needs review Needs review to determine if still applicable

Comments

@AlvaroBrey
Copy link
Member

AlvaroBrey commented Mar 8, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

This is a follow up for #36934. #37005 fixed the login failure but the styles still look strange in older webview versions. This is most noticeable on primary color buttons (missing the color) and text fields (wrong width). See screenshots below for comparison.

It looks fine on 25.0.1 but not 25.0.4 or master. It also looks fine on newer Webview versions but not on older Webview versions.

Screenshots
Old webview (nc 25.0.4/master) Old webview (nc 25.0.1) New webview (nc 25.0.4/master)
Screenshot_1678269784 Screenshot_1678270254 Screenshot_1678270495
Screenshot_1678269798 Screenshot_1678270301 Screenshot_1678270499
Screenshot_1678269803 Screenshot_1678270304 Screenshot_1678270529

Steps to reproduce

  1. Set up 25.0.4 or master server
  2. Try to log in with the Android app on an older device
  3. See strange styles in

Expected behavior

Normal styles 🤷

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

-

Nextcloud Signing status

No response

Nextcloud Logs

nextcloud.log

Additional info

Tested Webview versions:

  • Broken styles: 66.0.3359.158 (on Android 9)
  • Correct styles: 101.0.4951.74 (on Android 13)

Console logs of the webview when styles are wrong (server master):
toaster.lan-1678273224246.log

@AlvaroBrey AlvaroBrey added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback 26-feedback labels Mar 8, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2023

@AlvaroBrey I suppose some of the used css features are simply not available with Webview 66 yet, so I don't know if this is actually worth the trouble trying to find the things that don't work since this is mainly a cosmetic issue and fixable an android by updating the webview, correct?

@AlvaroBrey
Copy link
Member Author

@AlvaroBrey I suppose some of the used css features are simply not available with Webview 66 yet, so I don't know if this is actually worth the trouble trying to find the things that don't work since this is mainly a cosmetic issue and fixable an android by updating the webview, correct?

Indeed this is a narrow impact issue, it may not be worth it to fix it; however I was asked to post this here in order to at least leave it written down.

@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2023

however I was asked to post this here in order to at least leave it written down.

all right 👍

@joshtrichards joshtrichards added the needs review Needs review to determine if still applicable label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback 26-feedback bug design Design, UI, UX, etc. feature: authentication needs review Needs review to determine if still applicable
Projects
None yet
Development

No branches or pull requests

3 participants