Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Warning for X-Robots-Tag raises for the none value #37386

Closed
5 of 9 tasks
jooola opened this issue Mar 24, 2023 · 3 comments
Closed
5 of 9 tasks

[Bug]: Warning for X-Robots-Tag raises for the none value #37386

jooola opened this issue Mar 24, 2023 · 3 comments

Comments

@jooola
Copy link

jooola commented Mar 24, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

After upgrading to 25.0.5, I've checked the admin dashboard, and the I had the following warning:

"The X-Robots-Tag header is not equal to noindex, nofollow."

But I configured my web server to set this header to none which translates to noindex, nofollow.

From my nginx configuration:

  add_header X-Robots-Tag "none" always;

So I think the check should also include the none value.

Steps to reproduce

  1. Configure the web server to set the X-Robots-Tag header to none
  2. See warning

Expected behavior

No warning raised when using none for the X-Robots-Tag header.

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Irrelevant ?

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@jooola jooola added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 24, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 24, 2023

Cc @MichaIng

@ernolf
Copy link
Contributor

ernolf commented Mar 24, 2023

While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines. /pull/36689

@MichaIng MichaIng removed bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 24, 2023
@MichaIng
Copy link
Member

Also noted in pinged issue for developers and admins: #34692 (comment)

I will never add another admin check change without linking/explaining the reason right within the admin panel, people just keep asking instead of reading 😄. I already have another important change in pipeline regarding the X-XSS-Protection header 🙈.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants