Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon color broken in app-store #42998

Closed
szaimen opened this issue Jan 21, 2024 · 7 comments · Fixed by #44092
Closed

icon color broken in app-store #42998

szaimen opened this issue Jan 21, 2024 · 7 comments · Fixed by #44092
Assignees
@susnux
Labels
2. developing Work in progress design Design, UI, UX, etc. technical debt

Comments

@szaimen
Copy link
Contributor

szaimen commented Jan 21, 2024

See
image
@szaimen szaimen added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of accessibility and removed bug labels Jan 21, 2024
@JuliaKirschenheuter
Copy link
Contributor

It is not a11y issue but a visual bug. removing from the board

@szaimen szaimen self-assigned this Jan 24, 2024
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 24, 2024
@szaimen szaimen mentioned this issue Jan 24, 2024
Closed
@szaimen
Copy link
Contributor Author

szaimen commented Jan 24, 2024

I tried to fix this but unfortunately I gave up because apparently we need to use filter: var(--primary-invert-if-bright); in dark mode and filter: var(--primary-invert-if-dark); in light mode. Unfortunately I did not find a working solution for this. See my WIP in https://github.com/nextcloud/server/pull/43082/files

@szaimen szaimen removed their assignment Jan 24, 2024
@susnux
Copy link
Contributor

susnux commented Jan 24, 2024

icon classes 🎉 😔
We really need to get rid of them and just use inline svgs.

@szaimen szaimen assigned szaimen and unassigned szaimen Feb 2, 2024
@szaimen
Copy link
Contributor Author

szaimen commented Feb 9, 2024

I couldnt find a working solution :/

@jancborchardt
Copy link
Member

@sorbaugh small frontend bug that could be put on the "To do" as a small item whenever someone has time (we do it similarly in Talk).

@szaimen szaimen added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Feb 22, 2024
@susnux
Copy link
Contributor

susnux commented Feb 22, 2024

@jancborchardt will do as part of the appstore overhauling for the discover section

@susnux susnux self-assigned this Feb 22, 2024
@susnux susnux added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 22, 2024
@susnux susnux mentioned this issue Mar 8, 2024
Merged
4 tasks
@joshtrichards
Copy link
Member

Similar: #42803

@susnux susnux mentioned this issue Mar 10, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
2. developing Work in progress design Design, UI, UX, etc. technical debt
Projects
🖍 Design team
Archived in project
Milestone
No milestone
5 participants
@jancborchardt @joshtrichards @susnux @JuliaKirschenheuter @szaimen