Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Low contrast for HTML buttons in emails #43043

Closed
4 of 8 tasks
ChristophWurst opened this issue Jan 23, 2024 · 3 comments
Closed
4 of 8 tasks

[Bug]: Low contrast for HTML buttons in emails #43043

ChristophWurst opened this issue Jan 23, 2024 · 3 comments

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

Emails sent with 28.0.1 Emails sent with 28.0.2 RC1
Bildschirmfoto vom 2024-01-23 08-54-04 Bildschirmfoto vom 2024-01-23 08-53-50

Steps to reproduce

  1. Execute a Nextcloud action that sends out an email with a button

Expected behavior

Readable, accessible HTML button

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ShGKme
Copy link
Contributor

ShGKme commented Jan 23, 2024

I guess that the current button color is more contrast formally by the number, because "before" it was not contrast enough.

Most likely the same change as in other elements with primary style.

image

@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

It seems the email is forced to be white background but primary colors for dark theme are used. So probably the HTML needs data-theme="light" or similar set.

@skjnldsv
Copy link
Member

FIxed with 30. Will also be improved with #48095

@skjnldsv skjnldsv closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants