Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Redundant index oc_filecache.fs_parent #43105

Open
4 of 8 tasks
ChristophWurst opened this issue Jan 25, 2024 · 2 comments
Open
4 of 8 tasks

[Bug]: Redundant index oc_filecache.fs_parent #43105

ChristophWurst opened this issue Jan 25, 2024 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: filesystem performance 🚀

Comments

@ChristophWurst
Copy link
Member

⚠️ This issue respects the following points: ⚠️

Bug description

create index fs_parent
    on nextclouddev.oc_filecache (parent);

create index fs_parent_name_hash
    on nextclouddev.oc_filecache (parent, name);
  • the database can use fs_parent_name_hash for any operation it would have used fs_parent
  • INSERT and DELETE have to maintain both indices
  • UPDATES of parent have to both indices

Steps to reproduce

  1. Install Nextcloud

Expected behavior

Efficient use of database indices

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of performance 🚀 labels Jan 25, 2024
@ChristophWurst
Copy link
Member Author

@sorbaugh I'm not a files backend expert. Could I ask you to validate the idea please?

@ChristophWurst
Copy link
Member Author

fs_parent was added with #36701. According to #36701 (comment) it's the size of the concatenated index that makes it sub optimal.

@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: filesystem performance 🚀
Projects
None yet
Development

No branches or pull requests

3 participants