From 4e0286ff9e883c23e529deb8f8e295c26bd591f2 Mon Sep 17 00:00:00 2001
From: Joas Schilling <coding@schilljs.com>
Date: Tue, 8 Oct 2024 10:07:26 +0200
Subject: [PATCH] feat(max-duration): Add setupcheck for misconfiguration

Signed-off-by: Joas Schilling <coding@schilljs.com>
---
 lib/AppInfo/Application.php      |  2 ++
 lib/SetupCheck/Configuration.php | 55 ++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 lib/SetupCheck/Configuration.php

diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
index 903aa418bf8..2a54aca97bc 100644
--- a/lib/AppInfo/Application.php
+++ b/lib/AppInfo/Application.php
@@ -109,6 +109,7 @@
 use OCA\Talk\Settings\BeforePreferenceSetEventListener;
 use OCA\Talk\Settings\Personal;
 use OCA\Talk\SetupCheck\BackgroundBlurLoading;
+use OCA\Talk\SetupCheck\Configuration;
 use OCA\Talk\SetupCheck\FederationLockCache;
 use OCA\Talk\SetupCheck\HighPerformanceBackend;
 use OCA\Talk\SetupCheck\RecordingBackend;
@@ -341,6 +342,7 @@ public function register(IRegistrationContext $context): void {
 
 		$context->registerTeamResourceProvider(TalkTeamResourceProvider::class);
 
+		$context->registerSetupCheck(Configuration::class);
 		$context->registerSetupCheck(HighPerformanceBackend::class);
 		$context->registerSetupCheck(FederationLockCache::class);
 		$context->registerSetupCheck(RecordingBackend::class);
diff --git a/lib/SetupCheck/Configuration.php b/lib/SetupCheck/Configuration.php
new file mode 100644
index 00000000000..d788da0a079
--- /dev/null
+++ b/lib/SetupCheck/Configuration.php
@@ -0,0 +1,55 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+namespace OCA\Talk\SetupCheck;
+
+use OCP\AppFramework\Services\IAppConfig;
+use OCP\IConfig;
+use OCP\IL10N;
+use OCP\SetupCheck\ISetupCheck;
+use OCP\SetupCheck\SetupResult;
+
+/**
+ * Check app configs and their dependencies
+ */
+class Configuration implements ISetupCheck {
+	public function __construct(
+		protected IL10N $l10n,
+		protected IConfig $config,
+		protected IAppConfig $appConfig,
+	) {
+	}
+
+	public function getCategory(): string {
+		return 'talk';
+	}
+
+	public function getName(): string {
+		return $this->l10n->t('Talk configuration');
+	}
+
+	public function run(): SetupResult {
+		$errors = $warnings = [];
+		$maxCallDuration = $this->appConfig->getAppValueInt('max_call_duration');
+		if ($maxCallDuration > 0) {
+			if ($this->config->getAppValue('core', 'backgroundjobs_mode', 'ajax') !== 'cron') {
+				$errors[] = $this->l10n->t('Forcing a call duration is only supported with system cron. Please enable system cron or remove the `max_call_duration` configuration.');
+			} elseif ($maxCallDuration < 3600) {
+				$warnings[] = $this->l10n->t('Small `max_call_duration` values (currently set to %d) are not enforceable due to technical limitations. The background job is only executed every 5 minutes, so use at own risk.', [$maxCallDuration]);
+			}
+		}
+
+		if (!empty($errors)) {
+			return SetupResult::error(implode("\n", $errors));
+		}
+		if (!empty($warnings)) {
+			return SetupResult::warning(implode("\n", $warnings));
+		}
+		return SetupResult::success();
+	}
+}