Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent call setting could be remembered per-room #10085

Closed
jancborchardt opened this issue Aug 1, 2023 · 2 comments · Fixed by #11719
Closed

Silent call setting could be remembered per-room #10085

jancborchardt opened this issue Aug 1, 2023 · 2 comments · Fixed by #11719
Assignees
Milestone

Comments

@jancborchardt
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
We have both our team calls and design review calls in the "Design team public" channel. For neither we really want to ring all of the 90+ participants in the channel. We like the silent call feature a lot for that but sometimes we forget to use it.

Describe the solution you'd like
Since we always use the silent call feature for every call in that room (except if we forget), it seems it would be apt to remember this setting per-room, much like the video and audio settings are as well.

Describe alternatives you've considered
Alternative would be to globally remember, but this does not make a lot of sense as different rooms have different contexts.

@Antreesy
Copy link
Contributor

Antreesy commented Nov 15, 2023

We may reuse a current logic for showing MediaSettings via Pinia store (as well as for some other 'per-conversation' params kept in BrowserStorage):

  • audioDisabled_
  • videoDisabled_
  • virtualBackgroundEnabled_
  • virtualBackgroundType_
  • virtualBackgroundBlurStrength_
  • virtualBackgroundUrl_
  • silentCall_

getShowMediaSettings: (state) => (token) => {

@Antreesy
Copy link
Contributor

related TODO:

virtualBackground should be updated on room switch => model might remember Blur, although current setting is None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants