-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow-up(SystemMessageGroup) - improve behaviour #10758
Comments
Just a thought if we are keeping the read marker logic : For LeftSidebar, either we do the same ( keep it not collapsed by default if it is the last message) or we can reflect this "nested" format ( collapsed message > combined message > MessagesSystemGroup) in the store so we can get the combined message and render it in Conversation. |
This is solved for now, right? |
No, only sorting messages was solved. |
Left sidebar I think not grouping is okay. The readmarker could be because of mixed up sorting. But then it would be live already on our server and others reported just again that it happens, so yeah might still have issues. |
As I checked last time, it was because of the collapsing messages ( read marker clears the counter only when it is visible) |
maybe we then switch and make it group on the last one (or well set the last message's id as the visible message id on the element?) |
The thing is the grouped message is not actually a message where we can get its id. It is not stored but kinda "computed" ? |
Or we keep it simple and only show non-combined messages as last message? Simplicity is key! |
The issue was that, because in the chat view, you don't see the last non-combined message but you see its "parent" combined message. A simple solution would be the following: @Antreesy what do you think ? |
We can change that to have the last message id instead of the first as pointed out before :) |
How to use GitHub
Follow-up / Regression fixes for #9777:
Showing in LeftSidebar in conversationFeel free to add items to the list
The text was updated successfully, but these errors were encountered: