Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in the style of tab headers between Talk and server #1390

Closed
danxuliu opened this issue Dec 13, 2018 · 2 comments
Closed

Differences in the style of tab headers between Talk and server #1390

danxuliu opened this issue Dec 13, 2018 · 2 comments

Comments

@danxuliu
Copy link
Member

@nextcloud/designers and, specially, @jancborchardt , as you made the style of tab headers in Talk and in the server.

There are some differences (besides the position of the icon) in those styles:

  • Padding (larger in Talk, 12px instead of 5px)
  • Underline of inactive tab (shown in Talk, and explicitly mentioned as a fix in the pull request for Talk, while not shown in server)
  • Opacity of inactive tab (in Talk is lower than the active tab, in server is the same)
  • Highlight of hovered tab (in Talk the whole tab header is highlighted, in the server only the underline is highlighted)

I think that all this should be unified but, how? Personally I prefer the style of Talk regarding inactive and hovered tabs, and I have no preference regarding the padding.

@skjnldsv
Copy link
Member

@danxuliu this is really nice talk to have! Since we're soon going to create the standard on the sidebar, this is feedback like that we need :)

Could you put details and screenshots in nextcloud/server#10289 ?

@nickvergessen
Copy link
Member

We are using the sidebar component now, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants