Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Comments #109

Open
alantygel opened this issue Sep 6, 2017 · 11 comments
Open

[Feature Request] Comments #109

alantygel opened this issue Sep 6, 2017 · 11 comments

Comments

@alantygel
Copy link

Hi there,

I'm looking forward to be able to have comments on a task. When several users are sharing a calendar, and its associated tasks, I would like these users to be able to make comments over it (identified, and dated).

Is this functionality on the roadmap? Any hints on how to implement it?

best,
alan

@raimund-schluessler
Copy link
Member

This is certainly a nice improvement. Best would be to have it integrated the Nextcloud comment feature. I cannot tell, when this will be implemented, since for this to make sense, we would first need to implement the ability to share task lists with other users directly from Tasks.

@alantygel
Copy link
Author

Great, thanks for the answer.

since for this to make sense, we would first need to implement the ability to share task lists with other users directly from Tasks.

As far as I understand, tasks associated to a calendar can already be shared (when the calendar is shared). In this case, comments already make sense. Right?

Together with some colleagues - @dtygel and @viniciuscb, we are considering contributing to the project in this sense. We noticed that there are some comments on the code regarding this issue (

<!-- <div class="section detail-comments">
).

If possible, please leave here some considerations you may have about it.

best,
alan

@raimund-schluessler
Copy link
Member

Together with some colleagues - @dtygel and @viniciuscb, we are considering contributing to the project in this sense.

Great to hear, contributions are always welcome!

As far as I understand, tasks associated to a calendar can already be shared (when the calendar is shared). In this case, comments already make sense. Right?

Yes, that's right. If you have the Calendar app enabled, you can share calendars with other users and in case these calendars have tasks, you will see them in the Tasks app. In this case, having comments is definitively useful.

We noticed that there are some comments on the code regarding this issue

Right. Comments were implemented in an earlier version, but were not reimplemented after the move to the Nextcloud internal CalDAV server, since there was always some more important aspect of the app to work on.

As for the frontend, I would put the comments at the same place they were before in

<!-- <div class="section detail-comments">

but use a styling similar to the one in the files app
screenshot-2017-9-7 dateien - nextcloud

Regarding the backend, I would implement it differently that it used to be. Before, I stored the comments in the ics entry, which required handling the userID and commentID manually. The benefit was, that every standard CalDAV client would have been able to see the comments, but none of the clients I am aware used to do that. Also, this was quite errorprone and is not possible at all anymore, since the CalDAV server of core is used now.
Now, I think, the comments app in server which is used for the comments on a file or folder, should be used here as well: https://github.com/nextcloud/server/tree/master/apps/comments. I haven't had a look how it works yet, but it should be possible to use this app for the comments on tasks and events.

@alantygel
Copy link
Author

Danke schön, Raimund!

We'll start evaluating the code here, and we'll get in touch as soon as we have some advances here.

@marcusitpro
Copy link

Dear, Any progess on the proposed solution? I'd be extra grateful for that appeal. It's a great use for everyone.

@dtygel
Copy link

dtygel commented Nov 24, 2017

@marcusitpro yes, we have a working solution! We'll create a PR very soon.

@AlekseyFR
Copy link

Up
Dear, Any progess on the proposed solution? I'd be extra grateful for that appeal. It's a great use for everyone.

@raimund-schluessler raimund-schluessler changed the title [Feature Request] Comments in Tasks [Feature Request] Comments Jun 19, 2018
@ghost
Copy link

ghost commented May 10, 2019

Any updates? I'm also interested in this.

@ghost
Copy link

ghost commented May 28, 2019

@dtygel What happened with the PR? Approaching 2 years now.

@itkfm
Copy link

itkfm commented Oct 19, 2020

Currently using the label-less description/comment/whatsoever box for this.
It works to some extent, but it doesn't really do the job. Quite a pity there's no better solution…

@theorosendorf
Copy link

Many would consider discussing with colleagues on individual tasks one of the most basic requirements of a task app. Is this feature on the horizon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants