Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate popup does not open in mobile apps #4233

Closed
thgoebel opened this issue Jun 1, 2023 · 5 comments · Fixed by #5197
Closed

Translate popup does not open in mobile apps #4233

thgoebel opened this issue Jun 1, 2023 · 5 comments · Fixed by #5197
Assignees
Labels

Comments

@thgoebel
Copy link

thgoebel commented Jun 1, 2023

Describe the bug

The Translate popup never appears in the Rich Text Editor (Nextcloud Text) in the mobile apps.

Both in the Files Android+iOS apps but also in the Nextcloud Notes Android+iOS apps.
I'm opening this here centrally, instead of creating 4 separate issues for (Files, Notes) x (Android, iOS). Feel free to move it.

Steps To Reproduce

  1. Open a document with the Rich Text editor in Files or Nextcloud Notes in the Android or iOS app.
  2. Click on ...
  3. Click on Translate

Expected behavior

The Translate popup should open.

Actual behavior

Nothing happens.

Screenshots

n/a

Client details:

Device 1:

  • OS: iPadOS 16.5
  • Device: iPad Pro 2020
  • Files app: 4.8.0.5
  • Notes app: 4.1.7

Device 2:

  • OS: Android 13
  • Device: OnePlus 5
  • Files app: 3.24.1
  • Notes app: 4.0.0
Server details

Text app version: 3.7.2

Translate app version: 1.1.3

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: 26.0.2

Logs

Nextcloud log (data/nextcloud.log)

n/a

Browser log

n/a
@thgoebel thgoebel added the bug Something isn't working label Jun 1, 2023
@blizzz
Copy link
Member

blizzz commented Jun 16, 2023

switching triage label as i do not have either android nor ios devices

@juliushaertl
Copy link
Member

Endpoints only became public with nextcloud/server@e5d0ff0 so might be that this is only an issue on 26.

@thgoebel
Copy link
Author

thgoebel commented Jun 19, 2023

I've upgraded my instance to 27.0.0 (with Text 3.8.0 and Translate 1.1.3) and this is still an issue.

@Hephi2
Copy link
Contributor

Hephi2 commented Jun 29, 2023

There seem to be problems with loading the state.
The translation modal opens when adding the fallback value false in line

canDetect: loadState('text', 'translation_can_detect'),

However, all loadState commands seem to fail and just return the fallback value so translation is not possible.
This needs to be further inverstigated.

@juliushaertl
Copy link
Member

The state is usually added through this function:

public function provideState(): void {

However it seems with direct editing we only manually put the direct editing state in there:

$this->initialStateService->provideInitialState('text', 'directEditingToken', $token->getToken());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants