Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help text explaining that --skip and --exact are covered by filter expressions #29

Closed
Tracked by #158
sunshowers opened this issue Feb 12, 2022 · 3 comments
Closed
Tracked by #158
Labels
enhancement New feature or request
Milestone

Comments

@sunshowers
Copy link
Member

No description provided.

@KaranLMungra
Copy link

hey @sunshowers can you describe the --skip and --exact args in more details.

@sunshowers
Copy link
Member Author

sunshowers commented Mar 22, 2022

Hi @KaranLMungra -- the options basically should mirror what cargo test -- --skip and --exact does, and I'd use those as a reference. However, I'd hold off on doing these as they're probably covered by #117 (and the impl should probably just translate such requests into expressions).

@sunshowers
Copy link
Member Author

I think this use case is sufficiently covered by #117:

  • --skip foo is -E '!test(foo)'
  • --exact foo is -E 'test(=foo)'

These flags also become really hard to reconcile with filter expressions in general.

I'll leave this open until filter expressions are no longer experimental. We may also want to add help text explaining that --skip and --exact are covered by filter expressions instead.

@sunshowers sunshowers changed the title Add support for --skip and --exact to cargo nextest run Add help text explaining that --skip and --exact are covered by filter expressions Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants