From 61aeda64010fe2faa1aa10daa69f663fa8a042d2 Mon Sep 17 00:00:00 2001 From: Victor Lin <13424970+victorlin@users.noreply.github.com> Date: Mon, 24 Oct 2022 14:50:20 -0700 Subject: [PATCH] Drop based on pre-computed isnull() instead of dropna() Both Series.isnull() and DataFrame.dropna() accomplish the same thing, but use just one to improve readability. --- augur/filter.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/augur/filter.py b/augur/filter.py index 2c04ffff5..6f03746b3 100644 --- a/augur/filter.py +++ b/augur/filter.py @@ -1052,7 +1052,7 @@ def get_groups_for_subsampling(strains, metadata, group_by=None): if 'year' in generated_columns_requested: # Skip ambiguous years. df_skip = metadata[metadata[f'{temp_prefix}year'].isnull()] - metadata.dropna(subset=[f'{temp_prefix}year'], inplace=True) + metadata.drop(df_skip.index, inplace=True) for strain in df_skip.index: skipped_strains.append({ "strain": strain, @@ -1066,7 +1066,7 @@ def get_groups_for_subsampling(strains, metadata, group_by=None): if 'month' in generated_columns_requested: # Skip ambiguous months. df_skip = metadata[metadata[f'{temp_prefix}month'].isnull()] - metadata.dropna(subset=[f'{temp_prefix}month'], inplace=True) + metadata.drop(df_skip.index, inplace=True) for strain in df_skip.index: skipped_strains.append({ "strain": strain, @@ -1083,7 +1083,7 @@ def get_groups_for_subsampling(strains, metadata, group_by=None): if 'week' in generated_columns_requested: # Skip ambiguous days. df_skip = metadata[metadata[f'{temp_prefix}day'].isnull()] - metadata.dropna(subset=[f'{temp_prefix}day'], inplace=True) + metadata.drop(df_skip.index, inplace=True) for strain in df_skip.index: skipped_strains.append({ "strain": strain,