From df73174a45a760c5f63f7a173543228da108b2f7 Mon Sep 17 00:00:00 2001
From: Victor Lin <13424970+victorlin@users.noreply.github.com>
Date: Fri, 9 Feb 2024 12:02:09 -0800
Subject: [PATCH] Expand boolean query tests

---
 .../filter/cram/filter-query-boolean.t        | 45 +++++++++++++++++--
 1 file changed, 42 insertions(+), 3 deletions(-)

diff --git a/tests/functional/filter/cram/filter-query-boolean.t b/tests/functional/filter/cram/filter-query-boolean.t
index 8b89ef356..32207e704 100644
--- a/tests/functional/filter/cram/filter-query-boolean.t
+++ b/tests/functional/filter/cram/filter-query-boolean.t
@@ -2,7 +2,7 @@ Setup
 
   $ source "$TESTDIR"/_setup.sh
 
-Create metadata file for testing.
+A column with True and False values is query-able by boolean comparisons.
 
   $ cat >metadata.tsv <<~~
   > strain	column
@@ -11,8 +11,6 @@ Create metadata file for testing.
   > SEQ_3	False
   > ~~
 
-The column is query-able by boolean comparisons.
-
   $ ${AUGUR} filter \
   >  --metadata metadata.tsv \
   >  --query "column == True" \
@@ -24,3 +22,44 @@ The column is query-able by boolean comparisons.
   $ sort filtered_strains.txt
   SEQ_1
   SEQ_2
+
+Empty values are ignored.
+
+  $ cat >metadata.tsv <<~~
+  > strain	column
+  > SEQ_1	True
+  > SEQ_2	False
+  > SEQ_3	
+  > ~~
+
+  $ ${AUGUR} filter \
+  >  --metadata metadata.tsv \
+  >  --query "column == True" \
+  >  --output-strains filtered_strains.txt
+  2 strains were dropped during filtering
+  	2 were filtered out by the query: "column == True"
+  1 strain passed all filters
+
+  $ sort filtered_strains.txt
+  SEQ_1
+
+It's possible to have only True values.
+
+  $ cat >metadata.tsv <<~~
+  > strain	column
+  > SEQ_1	True
+  > SEQ_2	True
+  > SEQ_3	True
+  > ~~
+
+  $ ${AUGUR} filter \
+  >  --metadata metadata.tsv \
+  >  --query "column == True" \
+  >  --output-strains filtered_strains.txt
+  0 strains were dropped during filtering
+  3 strains passed all filters
+
+  $ sort filtered_strains.txt
+  SEQ_1
+  SEQ_2
+  SEQ_3