Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: Pass encoding and newline keyword arguments to open_file #829

Open
huddlej opened this issue Jan 14, 2022 · 0 comments
Open

io: Pass encoding and newline keyword arguments to open_file #829

huddlej opened this issue Jan 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@huddlej
Copy link
Contributor

huddlej commented Jan 14, 2022

Context
Since version 1.3.0, xopen supports passing encoding and newline arguments through to the lower level open function calls for each compression method. When we added the io module to augur, we had to accept that we could not pass these arguments to the new open_file function because they wouldn't be accepted by xopen.

Description
We should require xopen version >=1.3.0 in our dependencies here and in the Bioconda recipe and update our internal calls to open_file to use encoding and newline arguments. We should also explicitly define these as keyword arguments for open_file to better document their availability.

Alternately, we could still consider implementing our own compression layer that will allow us to have more control over compression parameters like XZ compression, etc.

@huddlej huddlej added the enhancement New feature or request label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant