You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
We should require xopen version >=1.3.0 in our dependencies here and in the Bioconda recipe and update our internal calls to open_file to use encoding and newline arguments. We should also explicitly define these as keyword arguments for open_file to better document their availability.
Alternately, we could still consider implementing our own compression layer that will allow us to have more control over compression parameters like XZ compression, etc.
The text was updated successfully, but these errors were encountered:
Context
Since version 1.3.0, xopen supports passing
encoding
andnewline
arguments through to the lower levelopen
function calls for each compression method. When we added theio
module to augur, we had to accept that we could not pass these arguments to the newopen_file
function because they wouldn't be accepted byxopen
.Description
We should require xopen version >=1.3.0 in our dependencies here and in the Bioconda recipe and update our internal calls to
open_file
to useencoding
andnewline
arguments. We should also explicitly define these as keyword arguments foropen_file
to better document their availability.Alternately, we could still consider implementing our own compression layer that will allow us to have more control over compression parameters like XZ compression, etc.
The text was updated successfully, but these errors were encountered: