From 2175a100b2817f1709e271f2b044cc2a3727c335 Mon Sep 17 00:00:00 2001 From: Victor Lin <13424970+victorlin@users.noreply.github.com> Date: Wed, 13 Dec 2023 16:02:22 -0800 Subject: [PATCH 1/2] Remove unused ESLint exceptions Maybe ESLint was used in this codebase at some point, but right now it's not. In any case, these are unnecessary when ESLint is properly configured with eslint-plugin-react. --- auspice_client_customisation/splash.js | 2 +- auspice_client_customisation/styles.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/auspice_client_customisation/splash.js b/auspice_client_customisation/splash.js index 05eef96..b2140d6 100644 --- a/auspice_client_customisation/splash.js +++ b/auspice_client_customisation/splash.js @@ -1,4 +1,4 @@ -import React from "react"; // eslint-disable-line +import React from "react"; import { handleDroppedFiles } from "./handleDroppedFiles"; import { P, Bold, Title, NextstrainTitle, CenterContent, Line, GitHub } from './styles'; import pkg from "../package.json"; diff --git a/auspice_client_customisation/styles.js b/auspice_client_customisation/styles.js index ad8a768..1dace1b 100644 --- a/auspice_client_customisation/styles.js +++ b/auspice_client_customisation/styles.js @@ -1,4 +1,4 @@ -import React from "react"; // eslint-disable-line +import React from "react"; import styled from 'styled-components'; const logoPNG = require("./nextstrain-logo-small.png"); const gitHubLogo = require("./GitHub-Mark-32px.png"); From e0a0919015f70b41e365926296502339c29e6119 Mon Sep 17 00:00:00 2001 From: Victor Lin <13424970+victorlin@users.noreply.github.com> Date: Wed, 13 Dec 2023 16:00:15 -0800 Subject: [PATCH 2/2] Add CI to run build Heroku's PR review apps already show build failures on the PR pages, but this provides a more direct way to view build logs. --- .github/workflows/ci.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..6695c45 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,19 @@ +name: CI + +on: + push: + branches: + - master + pull_request: + workflow_dispatch: + +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: '16' + - run: npm ci + - run: npm run build