CI doesn't run against updated master branch

[jameshadfield]

The GitHub CI should run tests against a merge of the PRs branch into master, via the actions/checkout@v2 module with default settings (docs here, code here).

PR #1087 failed the bundlesize CI

FAIL  ./dist/auspice.bundle.js: 194.2KB > maxSize 180KB (gzip) 

I decided to update the allowed bundle sizes to 200KB and pushed this change to master via 90d91e9 (I did not touch this PR). I then manually triggered "re-run jobs", however the CI continued to fail using the "old" limits (180KB). I merged it anyway, and the master branch CI passed as expected.

The actual checkout command (via the CI logs, link above) is /usr/bin/git checkout --progress --force -B svg-in-md refs/remotes/origin/svg-in-md and doesn't seem to include a merge into master, however other PRs have behaved as if they are running the CI on a merge of the PR into master (or vice versa).

1. Can we confirm that the CI on a PR is being run on a merge of the PR into master?
2. When master has been updated, how can I re-trigger the CI to run and include the new changes present in master?

[ldosse]

Hello! I would like to help out with this issue but I am not sure I get it (also, first-time contributor).

My understanding of the issue is that your PR didn't catch the new changes on the Master. And since the CI runs on the PR branch, it used the old values.

Do you think a git pull from Master into the PR branch can be done first before running the tests or in case the CI fails? Alternatively, I am thinking maybe a cherry-pick to the PR branch would do the same thing but might be manual.

[sinloes]

@jameshadfield I would also like to help with this as part of a school project. Where exactly do I start with something like this? Do I make a pull request?

[victorlin]

CI now runs on the GitHub Actions workflow's pull_request trigger, which does a merge with master before running.

auspice/.github/workflows/ci.yaml

Line 6 in 07c77f4

pull_request: