Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make titlebar component responsive #122

Closed
jameshadfield opened this issue Jan 26, 2017 · 4 comments · Fixed by #204
Closed

make titlebar component responsive #122

jameshadfield opened this issue Jan 26, 2017 · 4 comments · Fixed by #204

Comments

@jameshadfield
Copy link
Member

(after #121)

@trvrb
Copy link
Member

trvrb commented Feb 21, 2017

@jameshadfield ---

I tried to do this in #189, but ran into an issue with making putting browserDimensions into redux in index.js instead of app.js (one level up). I got the redux boilerplate working, but couldn't figure out how to get dispatch going.

I thought it would be easiest to make titlebar responsive by making browserDimensions available everywhere and then just querying browserDimensions.width to see whether to draw the "nextstrain" logotype or to draw the circular logo.

If this sounds reasonable to you, would you mind taking a look at getting browserDimensions working throughout static content?

@jameshadfield
Copy link
Member Author

No problem - this is done in branch browser-dimensions

If it looks good then you can merge into your working branch I think

@trvrb
Copy link
Member

trvrb commented Feb 21, 2017

Awesome. This is super clean. Thanks James.

@jameshadfield
Copy link
Member Author

jameshadfield commented Feb 22, 2017

Browser dimensions bug now fixed in master - 3af9398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants