Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dataset path to redux / react-router #161

Closed
trvrb opened this issue Feb 2, 2017 · 2 comments
Closed

Move dataset path to redux / react-router #161

trvrb opened this issue Feb 2, 2017 · 2 comments
Assignees

Comments

@trvrb
Copy link
Member

trvrb commented Feb 2, 2017

Currently logic of dataset path (ie /flu/h3n2/3y vs /zika/) is handled through direct manipulation of window via changeRoute in App. This should be moved to redux / react-router. We'll have stored state in redux and use router.push to update URL.

I'd propose to put this in store.controls alongside colorBy, layout, etc..., where store.controls.dataset still follows the scheme set up by @rneher in parseParams.

@trvrb trvrb self-assigned this Feb 2, 2017
@jameshadfield
Copy link
Member

Keeping this open for now, but moving to backlog, as we aim for launch.

For launch, RR will handle some paths, but parseParams will still be employed for the virus dataset logic.

@trvrb
Copy link
Member Author

trvrb commented Mar 15, 2017

We've just decided that the current setup with react-router loading App (https://github.com/nextstrain/auspice/blob/master/src/index.js#L41) and then App querying the URL (https://github.com/nextstrain/auspice/blob/master/src/components/app.js#L77) is the right way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants