Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle date slider #210

Closed
trvrb opened this issue Feb 25, 2017 · 2 comments
Closed

Throttle date slider #210

trvrb opened this issue Feb 25, 2017 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Feb 25, 2017

Manipulating date slider in production (see dev.nextstrain.org) causes too many redux updates to fire. You can see the URL spin while the date slider catches up. Redux events should be throttled.

@trvrb trvrb added the bug Something isn't working label Feb 25, 2017
@jameshadfield
Copy link
Member

Before I start this - do we still want the effects (tip vis) to change as often as they currently do? Because they get redux actions at the same frequency. Note that the URL is overwritten - it's not creating a bunch of history

@trvrb
Copy link
Member Author

trvrb commented Feb 27, 2017

Yes. Great with the history. I think you can just throttle redux actions to 100ms or whatever. Each event should update the URL and redraw tip visibilities. Okay to share redux updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants