Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard format for JSON filenames? #4

Closed
colinmegill opened this issue Aug 4, 2016 · 3 comments
Closed

Standard format for JSON filenames? #4

colinmegill opened this issue Aug 4, 2016 · 3 comments
Assignees

Comments

@colinmegill
Copy link
Collaborator

The nextstrain app route to dataset pipeline will look like this:

nextstrain.org/:virus/:strain/:timeperiod, thus: nextstrain.org/flu/h3n2/3y

How we map this to a REST route on the server, and then to string names on s3 is an open question

@trvrb
Copy link
Member

trvrb commented Aug 5, 2016

Good question. The current practice for S3 is:

/data/h3n2_3y_tree.json
/data/h3n2_3y_sequences.json
/data/zika_tree.json

The issue is, some viruses (like Ebola and Zika) have only one resolution (timeperiod) and only one lineage (strain).

What about just doing the exact same structure for S3? So

/data/flu/h3n2/3y/tree.json
/data/flu/h3n2/3y/sequences.json
/data/zika/tree.json

@colinmegill
Copy link
Collaborator Author

That's ideal, if it's not too inconvienient, as we can construct the request on the client

@trvrb
Copy link
Member

trvrb commented Aug 5, 2016

Seems entirely reasonable. Shouldn't be an issue with the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants