Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frequencies questions #505

Closed
jameshadfield opened this issue Feb 27, 2018 · 2 comments · Fixed by #518
Closed

frequencies questions #505

jameshadfield opened this issue Feb 27, 2018 · 2 comments · Fixed by #518

Comments

@jameshadfield
Copy link
Member

cc @huddlej @trvrb @rneher

Some relevant questions (add more as needed):

  • Should normalisation be the default?
  • How should residual error be dealt with? Currently if the raw frequency for a pivot is <0.01 I collapse it to zero -- the alternative being to expand what is probably rounding / smoothing errors to what looks like 100% frequency. But this approach leads to sawtooth like displays:
    image
@trvrb
Copy link
Member

trvrb commented Feb 27, 2018

@jameshadfield and @rneher: I thought a bit here and I came up with the following proposal:

  1. We properly normalize tip frequencies in augur before exporting to auspice. With all tips shown the frequencies display will look like:

all

  1. We keep only "raw" frequencies and disable normalization. However, we dynamically rescale the y axis to fill the plot, so that zooming to a clade A1 would look like:

clade

This should keep the app from getting into funny states and also keep the visualization well interpretable.

Even a very small clade ends up looking okay:

small_clade

Edit: Also, just realized that this is the only natural way to do "frequencies" for something like Ebola. In this case, "raw" should have something proportional to cases on the y, rather than frequencies. This decision can be made on a per-pathogen basis in augur.

@rneher
Copy link
Member

rneher commented Feb 28, 2018

this looks good to me (even though I still don't fully understand the notion of a tip frequency)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants