Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of dataset dropdown could be improved #705

Closed
trvrb opened this issue Feb 20, 2019 · 2 comments
Closed

Sorting of dataset dropdown could be improved #705

trvrb opened this issue Feb 20, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@trvrb
Copy link
Member

trvrb commented Feb 20, 2019

Currently, if the manifest lists something like:

            "h1n1pdm": {
              "segment": {
                "ha": {
                  "resolution": {
                    "2y": "",
                    "3y": "",
                    "6y": "",
                    "12y": "",
                    "pandemic": "",
                    "default": "3y"
                  }
                },

It will display as:

h1-options

where the default option of 3y gets sorted above all other options.

I think this looks strange in this case to have a list of menu options that go: 3y, 2y, 6y, 12y. I'd recommend just sticking with the ordering in the manifest JSON rather than moving default to top.

@trvrb trvrb added the enhancement New feature or request label Feb 20, 2019
@tsibley
Copy link
Member

tsibley commented Feb 20, 2019

This is the same request as #696.

I'd recommend just sticking with the ordering in the manifest JSON rather than moving default to top.

Note that regardless of the source text, JSON objects {…} don't have a particular key order defined: “An object is an unordered set of name/value pairs.” The select widgets must choose an explicit order to use at display time.

@trvrb
Copy link
Member Author

trvrb commented Feb 20, 2019

I see. I'll close this in favor of #696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants