Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is font-awesome actually used #828

Closed
jameshadfield opened this issue Nov 27, 2019 · 3 comments
Closed

is font-awesome actually used #828

jameshadfield opened this issue Nov 27, 2019 · 3 comments
Labels
performance improvement revisit sometime Useful to address but no bandwidth at the moment

Comments

@jameshadfield
Copy link
Member

The font-awesome CSS has been part of auspice from the very beginning, and thanks to #826 is now bundled as part of the auspice distribution.

I don't believe we actually use these styles in auspice & they should therefore be removed. Needs double checking as there may be something i've missed here.

In general, the styling in auspice is too complicated and reflects a project which has grown over the years without a prescribed way of handling styles. But this is a separate issue 😉

@trvrb
Copy link
Member

trvrb commented Nov 27, 2019

Uses that I could find with a fa fa- grep:

Generally, I like having Font Awesome available when I'm working on UI. I know that FA icons can be directly included as SVG elements, but this is rather tedious when developing. I'll try to look to see how many kb in the webpack dropping Font Awesome would save.

@jameshadfield
Copy link
Member Author

Ahh yes, we do use it. I've been a fan of react-icons in other projects which allows you to do things like

import { ICON_NAME } from "react-icons/fa";

Given that we are using it, this issue is very low priority.

@jameshadfield jameshadfield added revisit sometime Useful to address but no bandwidth at the moment and removed please take this issue labels Nov 27, 2019
@jameshadfield
Copy link
Member Author

Closing as this is listed in #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance improvement revisit sometime Useful to address but no bandwidth at the moment
Projects
None yet
Development

No branches or pull requests

2 participants