Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move subsampling by proximity into augur #816

Open
Tracked by #1481
sidneymbell opened this issue Dec 13, 2021 · 2 comments
Open
Tracked by #1481

Move subsampling by proximity into augur #816

sidneymbell opened this issue Dec 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@sidneymbell
Copy link
Collaborator

Context
The ability to subsample using a focal set and then background context selected by genetic relatedness is SUPER useful. We'd like to be able to do this for other pathogens.

Description
Move the subsampling logic that assigns proximity scores by genetic relatedness out of ncov and into augur proper.

Examples

Possible solution
(Optional)

@sidneymbell sidneymbell added the enhancement New feature or request label Dec 13, 2021
@huddlej
Copy link
Contributor

huddlej commented Dec 21, 2021

@jameshadfield has implemented our subsampling logic as a script in ncov, but we haven't revisited this with more testing. We originally planned to implement this as augur subsample (and @jameshadfield created a corresponding Augur PR), but it seemed likely at the time that we'd substantially change this subsampling logic and we didn't want to codify the current implementation in augur only to change it again.

Would you all be up for trying out James's script version of subsampling for SARS-CoV-2 or other pathogens? That could help us figure out if it's worth the effort to move into Augur...

@sidneymbell
Copy link
Collaborator Author

Oh awesome, thanks @huddlej and @jameshadfield! We'd be up for trying out the script and potentially helping to move things over to augur if helpful, although we probably won't be working on this until a bit later / early spring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants