Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard CI jobs for ingest workflow #21

Closed
joverlee521 opened this issue Dec 1, 2023 · 2 comments
Closed

Add standard CI jobs for ingest workflow #21

joverlee521 opened this issue Dec 1, 2023 · 2 comments

Comments

@joverlee521
Copy link
Contributor

The pathogen-repo-ci has been used for a while now for testing the phylogenetic workflow. We should have a similar CI workflow for the ingest workflow as they become a standard part of the pathogen workflows.

I don't think we want to the run the full ingest of all NCBI data for the CI workflow. Should this mimic the phylogenetic workflow and start the workflow from example data instead of downloading from NCBI? I think it would make sense to start from an example NCBI zip archive that we keep in version control.

I'd think the CI workflow would only test the core ingest workflow. The Nextstrain automation profile rules can be tested manually as we've done in the past.

@tsibley
Copy link
Member

tsibley commented Jan 10, 2024

+1. I'd suggest adding ingest CI as jobs in the existing pathogen-repo-ci workflow, rather than making a new separate ingest CI workflow which we have to promulgate everywhere.

@joverlee521
Copy link
Contributor Author

With nextstrain/.github#89, we are leaving the details of how the ingest CI workflow should work on a per pathogen repo basis. The ingest workflow is just required to have a build-configs/ci/config.yaml config file for running the CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants