Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow securityContext and podSecurityContext to be configurable via helm parameters #4942

Closed
vepatel opened this issue Jan 18, 2024 · 1 comment · Fixed by #5084
Closed
Assignees
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Milestone

Comments

@vepatel
Copy link
Contributor

vepatel commented Jan 18, 2024

Expose the securityContext resource to be fully configured via helm. Currently we use this approach to expose the resources configuration of the pod. This will mean changing the securityContext fields in the deployment and daemonset from being hardcoded to being a toYaml representation of the values file, e.g:

securityContext:
          {{- toYaml .Values.controller.securityContext | nindent 10 }}

and we can reference the securityContext and podSecurityContext schemas in our values schema.

This seems to be a common approach in other charts and allows the user full control over the resource, which still allowing us to deliver our current default values. As we do this it also makes sense to expose the podSecurityContext in the same way even though we do not currently use it.

@vepatel vepatel added proposal An issue that proposes a feature request backlog Pull requests/issues that are backlog items labels Jan 18, 2024
Copy link

Hi @vepatel thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@oseoin oseoin changed the title Allow allowPrivilegeEscalation to be configurable via helm parameters Allow securityContext and podSecurityContext to be configurable via helm parameters Jan 19, 2024
@vepatel vepatel added this to the v3.5.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Projects
Archived in project
1 participant