Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cancellation of NGINX Plus API calls #1478

Open
pleshakov opened this issue Jan 18, 2024 · 1 comment
Open

Implement cancellation of NGINX Plus API calls #1478

pleshakov opened this issue Jan 18, 2024 · 1 comment
Labels
area/reliability Reliability related backlog Currently unprioritized work. May change with user feedback or as the product progresses. blocked Blocked by other issue tracking To track external issues or changes that will affect NKG

Comments

@pleshakov
Copy link
Contributor

#1469 brought support for dynamic reconfiguration of NGINX Plus upstreams.
However, when making NGINX Plus API call (HTTP requests), we don't control they cancelation of those operations.

We'd like to control cancelations for two reasons:

  • graceful termination. When NGF terminates, it needs to finish any in-progress API calls.
  • configuring a API call timeout -- control how much time NGF allows for a successful API call

Acceptance criteria:

  • Implement cancelation.
  • Implement a reasonable timeout.

Blocked by nginxinc/nginx-plus-go-client#205
@pleshakov pleshakov mentioned this issue Jan 18, 2024
Merged
6 tasks
@mpstefan mpstefan changed the title Implement cancelation of NGINX Plus API calls Implement cancellation of NGINX Plus API calls Jan 29, 2024
@mpstefan mpstefan added area/performance Performance related area/reliability Reliability related blocked Blocked by other issue tracking To track external issues or changes that will affect NKG backlog Currently unprioritized work. May change with user feedback or as the product progresses. and removed area/performance Performance related labels Jan 29, 2024
@sjberman
Copy link
Contributor

Looks like nginxinc/nginx-plus-go-client#383 added support for this in the library, so we just need to pull those changes into our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/reliability Reliability related backlog Currently unprioritized work. May change with user feedback or as the product progresses. blocked Blocked by other issue tracking To track external issues or changes that will affect NKG
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleshakov @mpstefan @sjberman