Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the unused build_in_import_modules dictionary in ni-measurement-plugin-client-generator #979

Open
jayaseelan-james opened this issue Oct 11, 2024 · 0 comments
Open

Clean up the unused build_in_import_modules dictionary in ni-measurement-plugin-client-generator #979

jayaseelan-james opened this issue Oct 11, 2024 · 0 comments
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed

Comments

@jayaseelan-james
Copy link
Contributor

jayaseelan-james commented Oct 11, 2024 •
edited by ni-github-admins
Loading

Tech Debt

As discussed in this comment.

In #871, we hard-coded the 'import pathlib', but continued iterating through the built_in_import_modules dictionary, which only contained the 'import pathlib' string literal until it was removed in #900. The use of built_in_import_modules was eliminated in #931. As a result, the built_in_import_modules dictionary and the _PATH_IMPORT variable are no longer used or required and should be removed.

AB#2903265
@jayaseelan-james jayaseelan-james added tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Non-user-visible improvement to code or development process triage New issue that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayaseelan-james