Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include problem, when cmake on osx #672

Closed
xiazhibin opened this issue Jul 31, 2017 · 2 comments
Closed

include problem, when cmake on osx #672

xiazhibin opened this issue Jul 31, 2017 · 2 comments

Comments

@xiazhibin
Copy link

I clone the project , and make install.
In my cpp file, I must #include "nlohmann/json.hpp" not #include "json.hpp" as it mentions

Why?

@dan-42
Copy link
Contributor

dan-42 commented Jul 31, 2017

This is due the latest changes in the CMakeLists.txt to be consistent with the projects name and namespace. Also to avoid polute a systems include folder when other libraries might have a json.hpp as well.

And for full consistency, the develop-branch is preparing version 3.0.0 which will bring breaking changes as well.
If you do not need special features from the current develop-branch it might be advised for you to use the master branch as the lates stable release.

Nonetheless it might be an option to enable when running cmake && make install to define if it should be in a subfolder or not.

@xiazhibin
Copy link
Author

I see.Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants