-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include .npmrc for onbuild version #25
Comments
Doing as you suggest would break the image for anyone without a .npmrc in |
@md5 Well that wouldn't be good :) It would be nice if setting |
Hi @techniq Are you ok with me closing this out? It seems like you found a work around? |
Thanks! |
Also this is very dangerous. Potentially the .npmrc contains login credentials for the users account on a private registry or so! |
In this case one should ignore all hidden files by default, I find. |
This is a marker for those searching for the actual error message: postinstall: cannot run in wd %s %s (wd=%s) |
I have a need for including the ONBUILD COPY package.json .npmrc* /usr/src/app/ |
We probably will not do that, here is the reasons why:
|
Thanks - that's a very helpful explanation |
I ran into an issue where I needed to set
unsafe-perm=true
when usingnode:0.12-onbuild
but I couldn't get the setting to take using"config": { "unsafe-perm": true }
inpackage.json
. It would be nice if.npmrc
is also copied over when package.json is copied so we could configure npm beforenpm install
. I know we can always break glass and not use the-onbuild
version but it's convenient to use (can write myDockerfile
from memory without having to lookup the base to copy/paste).So in short, could we change:
to:
The text was updated successfully, but these errors were encountered: