Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Support dotall ('s' flag) in regexp #570

Open
boingoing opened this issue Jul 11, 2018 · 3 comments
Open

Support dotall ('s' flag) in regexp #570

boingoing opened this issue Jul 11, 2018 · 3 comments

Comments

@boingoing
Copy link
Contributor

  • Version: All
  • Platform: All
  • Subsystem: All

ChakraCore does not support the 's' regex flag so if Javascript code in node.js uses this flag, we will throw a syntax error. We can work around this by replacing '.' by something like '[\s\S]' and removing the flag but this is a temporary solution at best. When ChakraCore supports the dotall flag, we should remove any of these workarounds. Including this one: 783e99a

@boingoing
Copy link
Contributor Author

ChakraCore is tracking this via chakra-core/ChakraCore#2787

@rhuanjl
Copy link
Contributor

rhuanjl commented Sep 20, 2018

dotAll is now in chakracore master chakra-core/ChakraCore#5592 - assumedly need to wait for the next CC release for it to be in a release branch though.

@kfarnung
Copy link
Contributor

Yup, we'll pick this up in vNext.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants