From 3f432f829fdec2331186ef29feda2082df345c87 Mon Sep 17 00:00:00 2001 From: Deokjin Kim Date: Fri, 17 May 2024 00:44:13 +0900 Subject: [PATCH] doc: remove unavailable youtube link in pull requests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This video(https://www.youtube.com/watch?v=HW0RPaJqm4g) isn't available anymore. And I couldn't find a proper github code review tutorial clip yet. PR-URL: https://github.com/nodejs/node/pull/52982 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Zijian Liu Reviewed-By: Rich Trott Reviewed-By: Gerhard Stöbich Reviewed-By: Moshe Atlow Reviewed-By: Ulises Gascón --- doc/contributing/pull-requests.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index a2bd63d3572393..295e9d3695c47e 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -548,8 +548,7 @@ A pull request is approved either by saying LGTM, which stands for "Looks Good To Me", or by using GitHub's Approve button. GitHub's pull request review feature can be used during the process. For more information, check out -[the video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g) -or [the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests/). +[the official documentation](https://help.github.com/articles/reviewing-changes-in-pull-requests/). After you push new changes to your branch, you need to get approval for these new changes again, even if GitHub shows "Approved"