Skip to content

Commit

Permalink
Revert "src: skip test_fatal/test_threads for Debug builds"
Browse files Browse the repository at this point in the history
This reverts commit 1fc4d43.

PR-URL: #39954
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
addaleax authored and BethGriggs committed Sep 21, 2021
1 parent 842f936 commit 570bef1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/node-api/test_fatal/test_threads.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ const assert = require('assert');
const child_process = require('child_process');
const test_fatal = require(`./build/${common.buildType}/test_fatal`);

if (common.buildType === 'Debug')
common.skip('as this will currently fail with a Debug check ' +
'in v8::Isolate::GetCurrent()');

// Test in a child process because the test code will trigger a fatal error
// that crashes the process.
if (process.argv[2] === 'child') {
Expand Down

0 comments on commit 570bef1

Please sign in to comment.