From 81ddeb98f6a0f7a5165cd6e3b87cdaa550fdf3ec Mon Sep 17 00:00:00 2001
From: Gibson Fahnestock <gibfahn@gmail.com>
Date: Sun, 28 May 2017 13:35:33 +0100
Subject: [PATCH] readline: clean up event listener in onNewListener

Once the Readline interface is closed, the 'data' event listener should
be removed.

PR-URL: https://github.com/nodejs/node/pull/13266
Ref: https://github.com/nodejs/node/pull/9447#discussion_r86599214
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/readline.js                             | 3 +++
 test/parallel/test-readline-set-raw-mode.js | 6 ++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/readline.js b/lib/readline.js
index 60864f40afdbc1..6a1ed150d72cd2 100644
--- a/lib/readline.js
+++ b/lib/readline.js
@@ -1039,6 +1039,9 @@ function emitKeypressEvents(stream, iface) {
   } else {
     stream.on('newListener', onNewListener);
   }
+  if (iface) {
+    iface.once('close', () => { stream.removeListener('data', onData); });
+  }
 }
 
 /**
diff --git a/test/parallel/test-readline-set-raw-mode.js b/test/parallel/test-readline-set-raw-mode.js
index db42a5a9495a9e..ddffd131d0baff 100644
--- a/test/parallel/test-readline-set-raw-mode.js
+++ b/test/parallel/test-readline-set-raw-mode.js
@@ -74,6 +74,8 @@ assert(!rawModeCalled);
 assert(resumeCalled);
 assert(!pauseCalled);
 
+// One data listener for the keypress events.
+assert.strictEqual(stream.listeners('data').length, 1);
 
 // close() should call setRawMode(false)
 expectedRawMode = false;
@@ -86,5 +88,5 @@ assert(!resumeCalled);
 assert(pauseCalled);
 
 assert.deepStrictEqual(stream.listeners('keypress'), []);
-// one data listener for the keypress events.
-assert.strictEqual(stream.listeners('data').length, 1);
+// Data listener is removed once interface is closed.
+assert.strictEqual(stream.listeners('data').length, 0);