From d4a9e7f027a777854ef8ce78e99fa15f81c79116 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 10 Aug 2023 19:09:38 +0200 Subject: [PATCH] deps: remove usage of a C++20 feature from V8 We are not ready to compile with C++20 support yet. This is only a DCHECK that can be removed without affecting the behavior of release builds. PR-URL: https://github.com/nodejs/node/pull/49639 Reviewed-By: Jiawen Geng Reviewed-By: Rafael Gonzaga Reviewed-By: Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/52465 Reviewed-By: Matteo Collina Reviewed-By: Michael Dawson --- common.gypi | 2 +- deps/v8/src/compiler/graph-visualizer.cc | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index b7238f3d3eed77..d83cde6dfcde66 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.4', + 'v8_embedder_string': '-node.5', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/compiler/graph-visualizer.cc b/deps/v8/src/compiler/graph-visualizer.cc index 1b1b67c1abb3b1..69eab369411ec9 100644 --- a/deps/v8/src/compiler/graph-visualizer.cc +++ b/deps/v8/src/compiler/graph-visualizer.cc @@ -297,7 +297,6 @@ void JsonPrintAllSourceWithPositionsWasm( os << "\"inlinings\": {"; for (size_t i = 0; i < positions.size(); ++i) { if (i != 0) os << ", "; - DCHECK(source_map.contains(positions[i].inlinee_func_index)); size_t source_id = source_map.find(positions[i].inlinee_func_index)->second; SourcePosition inlining_pos = positions[i].caller_pos; os << '"' << i << "\": {\"inliningId\": " << i