Skip to content

Commit

Permalink
perf_hooks: fix checking range of options.figures in createHistogram
Browse files Browse the repository at this point in the history
For `options.figures`, number between 1 and 5 is allowed. So need
to use `validateInteger` to limit max as 5.

Refs: https://github.com/nodejs/node/blob/main/doc/api/perf_hooks.md#perf_hookscreatehistogramoptions
PR-URL: #45999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
deokjinkim authored and RafaelGSS committed Jan 20, 2023
1 parent f309e2a commit f050889
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
3 changes: 1 addition & 2 deletions lib/internal/histogram.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const {
validateInteger,
validateNumber,
validateObject,
validateUint32,
} = require('internal/validators');

const kDestroy = Symbol('kDestroy');
Expand Down Expand Up @@ -368,7 +367,7 @@ function createHistogram(options = kEmptyObject) {
} else if (highest < 2n * lowest) {
throw new ERR_INVALID_ARG_VALUE.RangeError('options.highest', highest);
}
validateUint32(figures, 'options.figures', 1, 5);
validateInteger(figures, 'options.figures', 1, 5);
return internalRecordableHistogram(new _Histogram(lowest, highest, figures));
}

Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-perf-hooks-histogram.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ const { inspect } = require('util');
});
});

// Number greater than 5 is not allowed
for (const i of [6, 10]) {
throws(() => createHistogram({ figures: i }), {
code: 'ERR_OUT_OF_RANGE',
});
}

createHistogram({ lowest: 1, highest: 11, figures: 1 });
}

Expand Down

0 comments on commit f050889

Please sign in to comment.