Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b7ac0c9eda0affcb84d37100361d756dc95d83d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c380ee6785b72fd2f24803de80bb412dfc32e8a9
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 30, 2020

  1. fs: accept non-32-bit length in writeBuffer 

    Since `length` is `size_t`, it can accept 64-bit integers too.

Refs: https://man7.org/linux/man-pages/man2/write.2.html
Fixes: #36643

PR-URL: #36667
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
    @RaisinTen @nodejs-github-bot
    RaisinTen authored and nodejs-github-bot committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    c380ee6 View commit details
    Browse the repository at this point in the history
Loading